Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout of Outbounds table on debug page #2130

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jkanywhere
Copy link
Contributor

@jkanywhere jkanywhere commented Apr 14, 2022

The two header rows on the HTML table for Outbounds on the debug page
now have the same number of cells.

This will make the columns line up properly.

  • Description and context for reviewers: one partner, one stranger
  • Docs (package doc)
  • Entry in CHANGELOG.md

@jkanywhere
Copy link
Contributor Author

Before:
image

After:
image

Copy link

@rabbbit rabbbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thx.

Copy link
Collaborator

@jronak jronak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jronak
Copy link
Collaborator

jronak commented Apr 19, 2022

@jkanywhere license/cla check seems to be stuck (you could push the same amended commit to trigger this check again)

@jkanywhere jkanywhere force-pushed the debug-outbounds-table branch 2 times, most recently from 935d003 to fbe48b9 Compare May 4, 2022 16:38
@jronak jronak closed this May 4, 2022
@jronak jronak reopened this May 4, 2022
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #2130 (cfbe060) into dev (707eebc) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Current head cfbe060 differs from pull request most recent head 02264c0. Consider uploading reports for the commit 02264c0 to get more accurate results

@@            Coverage Diff             @@
##              dev    #2130      +/-   ##
==========================================
- Coverage   87.75%   87.70%   -0.06%     
==========================================
  Files         253      251       -2     
  Lines       14090    14041      -49     
==========================================
- Hits        12365    12314      -51     
- Misses       1336     1338       +2     
  Partials      389      389              
Impacted Files Coverage Δ
x/debug/debug.go 86.95% <ø> (ø)
transport/tchannel/peer.go 94.73% <0.00%> (-2.64%) ⬇️
dispatcher_startup.go 91.07% <0.00%> (-1.79%) ⬇️
peer/hashring32/internal/hashring32/hashring32.go 96.21% <0.00%> (-1.09%) ⬇️
internal/observability/graph.go 93.12% <0.00%> (-0.63%) ⬇️
transport/internal/tlsmux/listener.go
transport/internal/tlsmux/conn_sniffer.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 707eebc...02264c0. Read the comment docs.

The two header rows in the HTML table for Outbounds on the debug page
now have the same number of cells.

This will make the columns line up properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants