Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix question marks in strings #1371 #1375

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix question marks in strings #1371 #1375

wants to merge 2 commits into from

Conversation

parsonsmatt
Copy link
Collaborator

Closes #1371

Before submitting your PR, check that you've:

  • Documented new APIs with Haddock markup
  • Added @since declarations to the Haddock
  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@parsonsmatt parsonsmatt mentioned this pull request Mar 17, 2022
Merged
arrowd
arrowd reviewed Feb 5, 2023
View reviewed changes
persistent/Database/Persist/Sql/Raw/Internal.hs
@@ -1,4 +1,6 @@
module Database.Persist.Sql.Raw where
-- | This module is a internal. Breaking changes to the API of this module will
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra a?

@Vlix
Copy link
Contributor

Vlix commented Mar 23, 2024

This PR just exports the Raw and Internal modules, what happened to the "question marks in strings"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arrowd arrowd arrowd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question marks inside of strings cause RawSQL to be sad
3 participants
@parsonsmatt @Vlix @arrowd