Clean warnings in persistent #1448
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parsonsmatt
commented
Dec 3, 2022
Comment on lines
+14
to
+15
| , modifyRunOnException | ||
| , setRunOnException |
There was a problem hiding this comment.
oops, this warrants a minor bump!
arrowd
reviewed
Jan 23, 2023
| @@ -44,6 +44,7 @@ import Data.Time (defaultTimeLocale) | |||
| import Data.Time.Clock.POSIX (posixSecondsToUTCTime) | |||
| #endif | |||
|
|
|||
| import Prelude | |||
There was a problem hiding this comment.
Why import this? There is no NoImplicitPrelude pragma in there.
There was a problem hiding this comment.
It's a trick to get fewer warnings over time. By putting Prelude import last, you don't get a warning if you have import Data.Semigroup (Semigroup(..)) above. This is nice for reducing warnings when compiling with different versions of base where more and more things are added to Prelude.
There was a problem hiding this comment.
Wow, didn't know that. I skimmed over this PR, looks fine. It'd be good to get this in, so I can build on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
@sincedeclarations to the Haddockstylish-haskellon any changed files..editorconfigfile for details)After submitting your PR:
(unreleased)on the Changelog