Derive {From,To}JSON for EntityDef
#1540
Conversation
...and its dependencies. Motivated by some orphan instances we have at `$WORK` to dump our `persistent` entities (i.e. our database schema) to JSON for manipulation elsewhere.
|
Not sure if you want |
|
Not sure that upstream wants this, but I'm interested in building stuff with this at work, so maybe others would find it useful. |
There was a problem hiding this comment.
I'm a little hesitant to incorporate this, because it sort of makes the JSON representation part of the public API.
Would you mind adding @since comments to the JSON instances with a comment saying that a breaking change to the JSON representation may not be considered a breaking change for PVP reasons?
persistent/ChangeLog.md
Outdated
| @@ -1,5 +1,10 @@ | |||
| # Changelog for persistent | |||
|
|
|||
| ## 2.14.7.0 (unreleased) | |||
There was a problem hiding this comment.
| ## 2.14.7.0 (unreleased) | |
| ## 2.14.7.0 |
I can release this asap
Yeah, I figured it wouldn't be a 100% uncontroversial change! So I don't mean to push for this strongly if you or other maintainers feel it's not the right move. |
...and its dependencies.
Motivated by some orphan instances we have at
$WORKto dump ourpersistententities (i.e. our database schema) to JSON for manipulation elsewhere.