Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable inplace pod resize featuregate #7196

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

mikkeloscar
Copy link
Contributor

@mikkeloscar mikkeloscar added do-not-merge major Major feature changes or updates, e.g. feature rollout to a new country, new API calls. labels Mar 22, 2024
@mikkeloscar mikkeloscar marked this pull request as ready for review March 22, 2024 20:26
Base automatically changed from kube-1.27 to dev March 25, 2024 09:14
@mikkeloscar mikkeloscar changed the base branch from dev to kube-1.29 April 23, 2024 08:56
Base automatically changed from kube-1.29 to dev April 29, 2024 12:45
@mikkeloscar mikkeloscar changed the base branch from dev to kube-1.30 June 5, 2024 06:46
Base automatically changed from kube-1.30 to dev June 24, 2024 11:52
Comment on lines +1096 to +1109
# enable InPlacePodVerticalScaling
#
# https://kubernetes.io/blog/2023/05/12/in-place-pod-resize-alpha/
enable_in_place_pod_vertical_scaling: "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you plan to use it for (and how)?
I think it might be interesting for Skipper deployment to use whole dedicated node resources.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the feature makes sense today, there are missing support in e.g. the Vertical pod autoscaler so it's maybe less interesting today.

Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge major Major feature changes or updates, e.g. feature rollout to a new country, new API calls.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants