Add Sender::force_send
#143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BTOdell
commented
Mar 16, 2024
| @@ -432,6 +436,42 @@ struct Chan<T> { | |||
| } | |||
|
|
|||
| impl<T> Chan<T> { | |||
| #[inline(always)] | |||
There was a problem hiding this comment.
I included this line to ensure there isn't a performance degradation from extracting out this function from the existing code.
|
Hi, thanks for the PR! I'll try to find time to review this in the next few days. One thing I would say is that there are some invariants to maintain here: in particular, send_timeout expects to be able to pull the old value back out of the queue afterwards, so care will need to be taken to not accidentally violate this. |
|
Hi there! I came across the discussion and found that we implemented the lossy channel in a similar way. It would be nice if flume officially support this feature. Is there any reason this PR is being blocked or anything needs help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #142
I haven't added any tests yet because I didn't know which test files to add them to.
I'd like to just add a couple smoke tests.