This repository has been archived by the owner on Aug 13, 2022. It is now read-only.
[WIP] Hooks #301
Merged
[WIP] Hooks #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
probably need to rebase. the old style config needed correction |
|
Ok 👍 |
|
This is not finished, just partly refactored and cleaned. |
craigh
reviewed
Mar 9, 2017
| * information regarding copyright and licensing. | ||
| */ | ||
|
|
||
| namespace Zikula\DizkusModule; |
There was a problem hiding this comment.
this directory has a typo Hander vs Handler and also the namespace should include the parent directory e.g. namespace Zikula\DizkusModule\HookHandler
There was a problem hiding this comment.
Fixed in awaiting PR as well as wrong namespace.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In progress #300 and #299