Skip to content
This repository has been archived by the owner on Aug 13, 2022. It is now read-only.

V4 hooks #317

Merged
merged 4 commits into from
Aug 30, 2017
Merged

V4 hooks #317

merged 4 commits into from
Aug 30, 2017

Conversation

Kaik
Copy link
Contributor

@Kaik Kaik commented Aug 30, 2017

Base topic provider and hook settings.
#300 #316

Inital stage for topic provider.
Initial stage for hooks settings via sf forms (proof of concept)
Not fully symfony forms solution but...
@craigh
Copy link
Member

craigh commented Aug 30, 2017

I've hope you've read this: https://github.com/zikula/core/tree/master/src/docs/Hooks

specifically this: https://github.com/zikula/core/blob/master/src/docs/Hooks/2.TaggedHookServices.md

regarding "Tagged Hook Services" and not using persisted hooks.

@Kaik
Copy link
Contributor Author

Kaik commented Aug 30, 2017

Well, yes I'm aware of those changes this is:

  1. Zikula 1.4.x version should work on 1.5
  2. I will go into this again for core 2.0 I expect some things to change.

Which way of merge should I chose so it will be easy to propagate those changes into higher versions? squash and merge ?

@craigh
Copy link
Member

craigh commented Aug 30, 2017

you can merge however you like. it is only a timeline difference.

my point was that if you are into now, you should make the changes now unless you are working for 1.4 compatibility

@Kaik
Copy link
Contributor Author

Kaik commented Aug 30, 2017

Yes this is 1.4 for 2.0 it would be easier to do this :) anyway this one will stay for 1.4 I will try to merge it with version for 2.0 and then update to new but first I need to finish hooks import, then forum moderation and all missing stuff for 1.4/1.5... then I will move to 2.0 and new features.

@Kaik Kaik merged commit 6f01159 into zikula-modules:v4 Aug 30, 2017
@Kaik
Copy link
Contributor Author

Kaik commented Aug 30, 2017

It might fail on install/upgrade I'm working on this now.

@Kaik Kaik deleted the v4_hooks branch August 30, 2017 11:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants