Choose Tuning via first argument to command #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s guitar generate guitar chords, else ukulele chords. Only import the function used from itertools, also makes it clear where it comes from. Run tests only when Tuning is Ukulele, as the are specific to Ukulele.
|
👍 |
make code easier to understand remove unused code
removed unnecessary variables
removed print_short method group assert statements in tests
added name property method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an argument is given and equals guitar generate guitar chords, else ukulele chords.
Only import the function used from itertools, also makes it clear where it comes from.
Run tests only when Tuning is Ukulele, as the are specific to Ukulele.
Thanks for this neat tool. I made some changes that you may find useful too.