Add custom nice!view widgets #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicell
force-pushed
the
nice-view-custom-screen
branch
2 times, most recently
from
1955a12
to
55f004b
Compare
Nicell
force-pushed
the
nice-view-custom-screen
branch
from
55f004b
to
fbc5403
Compare
|
I tried running the widgets and they work as expected. However, the widgets add a significant delay to the main thread and every 5-6th keypress gets ignored. |
|
I have been testing on nicell's fork the last week, and the widgets all work great, and I have not noticed any issues around delay at all. |
|
Hey. I rebased this branch with the main and now the display looks a bit stange. |
@mike1808 This seems to be from work that was merged around using mono theme by default. You can fix by setting |
Nicell
force-pushed
the
nice-view-custom-screen
branch
from
fbc5403
to
1559560
Compare
Nicell
force-pushed
the
nice-view-custom-screen
branch
from
1559560
to
cf185f9
Compare
caksoylar
reviewed
Jul 14, 2023
Nicell
force-pushed
the
nice-view-custom-screen
branch
from
cf185f9
to
7839c21
Compare
petejohanson
requested changes
Jul 18, 2023
Nicell
force-pushed
the
nice-view-custom-screen
branch
from
7839c21
to
72cb99d
Compare
caksoylar
reviewed
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for feedback on the structure of this. It's a bit annoying since a single canvas can take on multiple events (top one up to three on the left side), so this is an option. Maybe isn't the best.
Also working on making a better image for the right side than just a nice!view logo.