Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(shields): MurphPad #1786

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(shields): MurphPad #1786

wants to merge 1 commit into from

Conversation

lesshonor
Copy link
Contributor

@lesshonor lesshonor commented Apr 27, 2023 •
edited
Loading

  • Added matrix transforms for three optional layouts. This is a numpad, but notably the first three positions of column 0 are actually tact switches on the back of the PCB. I believe the new transforms make this clearer (the keymap appearance matches QMK Configurator now, too)
  • Tweaked default keymap:
    • more closely resembles the QMK Configurator default map (reduces confusion for users who are new to ZMK; also generally less niche)
    • more useful OOTB for ZMK (immediate access to output selection, easier BT profile switching).
  • Cleaned up formatting a bit.
  • Updated encoder configuration to current ZMK standards.
  • Avoid forcing RGB on for nice_nano.
  • Corrected the number of default LEDs. While some users may opt for less or more, there are exactly eight footprints on the PCB for 5050 SMD LEDs.

Board/Shield Check-list

  • This board/shield is tested working on real hardware
  • General consistent formatting of DeviceTree files
  • Keymaps do not use deprecated key defines (Check using the upgrader tool)

caksoylar
caksoylar approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@caksoylar caksoylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had noticed the discrepancies when comparing vs. the configurator, looks good to me.

@caksoylar caksoylar added shields PRs and issues related to shields refactor labels Jun 10, 2023
@lesshonor lesshonor mentioned this pull request Oct 18, 2023
Merged
@lesshonor lesshonor force-pushed the murphpad-refactor branch 2 times, most recently from b5e8868 to abda644 Compare October 20, 2023 02:38
@lesshonor lesshonor changed the title refactor: murphpad refactor(shields): MurphPad Oct 20, 2023
@lesshonor lesshonor force-pushed the murphpad-refactor branch 4 times, most recently from b5b4fa0 to e173060 Compare January 9, 2024 14:21
@lesshonor lesshonor force-pushed the murphpad-refactor branch 2 times, most recently from d8b0e5e to 639daad Compare February 11, 2024 15:13
@lesshonor
refactor(shields): MurphPad
a0706f8 
* Added matrix transforms for three optional layouts.

* Tweaked default keymap to be more immediately useful for ZMK and more
  closely resemble the default keymaps of non-ZMK firmware.

* Board-specific Kconfig settings migrated to main shield file, so they
  will be exposed to end-users through the setup script.

* Tidied formatting and shortened overlong layer labels.

* Aligned encoder configuration with current standards.

* Corrected default number of RGB LEDs.

* Enabled OLED by default in a less authoritarian way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caksoylar caksoylar caksoylar approved these changes

Assignees
No one assigned
Labels
refactor shields PRs and issues related to shields
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lesshonor @caksoylar