fix(boards): unify board I2C configuration, use TWI driver #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petejohanson
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
petejohanson@b74830b (the commit moving boards to pinctrl) used the
nrf-twimdriver for allnrfmicrorevisions and thebluemicro840.That driver does not seem to work with ZMK OLED screens for some reason. Both the issue and the fix were observed and tested with
nrfmicro_13_52833andnrfmicro_13with various shields.Note: the Corne-ish Zen V1 uses the same
nrf-twimdriver for its fuel gauge, that seems to work fine (tested on my Zen). The issue only occurs with the screens.