This repository has been archived by the owner on Jun 13, 2020. It is now read-only.
Fix key in an AppRole definition example #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AppRole.__init__ expects "secret_uses" key [0]. I fix docs and not AppRole.__init__, because Vault option is called "secret_id_num_uses" [1], so aomi should use "_uses" too. [0] https://github.com/Autodesk/aomi/blob/4f549dd2150a419e3012286ed996cf70077b1ea9/aomi/model/auth.py#L188 [1] https://www.vaultproject.io/docs/auth/approle.html#auth-approle-role-role_name-
|
TY for this! Checked and it is spelled right in |
Perhaps it'd be easier to reason about if aomi used the same property names. Vault itself is quite complex to me, and differing keywords don't help too much :) |
|
Captured in #129 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppRole.__init__expects "secret_uses" key.I fix docs and not
AppRole.__init__, because Vault option is calledsecret_id_num_uses, so aomi should use_usestoo.