backport 24.04: feat(mobileWizard): keep past scroll position #9371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eszkadev
approved these changes
Jun 28, 2024
In I02365ecef859fb6f199d14a12a49937d5a30b8e7 (#9230) we made the scroll position of a menu always return to the top. This was to avoid a bug where a submenu would keep its scroll, starting partway down and obscuring the top items. In the review, it was mentioned that it would be even better to keep the scroll position of the menu when returning to it. For simplicity I've opted to only keep the position of menus up of you (so exiting a submenu then reopening it will keep the position of the top menu, but not the submenu), I make no comment on which way would be better as a user Signed-off-by: Skyler Grey <[email protected]> Change-Id: If82ff0b586a65349452fe8ebfb7fa046e4f874fb
Minion3665
force-pushed
the
private/skyler/mobile-wizard-remember-positions
branch
from
2215fef
to
ed2ce29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #9277
Summary
TODO
Checklist
make checkmake runand manually verified that everything looks okay