Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport 24.04: feat(mobileWizard): keep past scroll position #9371

Merged
merged 1 commit into from
Jul 2, 2024
Merged

backport 24.04: feat(mobileWizard): keep past scroll position #9371

merged 1 commit into from
Jul 2, 2024
+6 −1

Commits on Jul 2, 2024

  1. feat(mobileWizard): keep past scroll position 

    In I02365ecef859fb6f199d14a12a49937d5a30b8e7
(#9230) we made the scroll position of a menu
always return to the top. This was to avoid a bug where a submenu would
keep its scroll, starting partway down and obscuring the top items.

In the review, it was mentioned that it would be even better to keep the
scroll position of the menu when returning to it. For simplicity I've
opted to only keep the position of menus up of you (so exiting a submenu
then reopening it will keep the position of the top menu, but not the
submenu), I make no comment on which way would be better as a user

Signed-off-by: Skyler Grey <[email protected]>
Change-Id: If82ff0b586a65349452fe8ebfb7fa046e4f874fb
    @Minion3665
    Minion3665 committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    ed2ce29 View commit details
    Browse the repository at this point in the history