Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiphase Hybrid - FY23 Q4 milestone (reinitialization/sharpening and pressure approach) #1065

Merged
merged 33 commits into from
Jul 9, 2024
Merged

Multiphase Hybrid - FY23 Q4 milestone (reinitialization/sharpening and pressure approach) #1065

merged 33 commits into from
Jul 9, 2024

Conversation

mbkuhn
Copy link
Contributor

@mbkuhn mbkuhn commented May 17, 2024 •
edited
Loading

Summary

Next step in incorporating multiphase hybrid into main. This PR should bring main up to the code version used for the FY23 Q4 milestone.

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

@mbkuhn
Copy link
Contributor Author

mbkuhn commented Jun 7, 2024

Passes unit tests and regression tests, as well as regression tests for exawind-driver. New exawind-driver reg tests will be added shortly to go with this.

@mbkuhn
Copy link
Contributor Author

mbkuhn commented Jun 7, 2024

PR is in place for reg tests (Exawind/exawind-driver#72). AMR-Wind PR should go in first, as well as a corresponding PR for Nalu-Wind, then the reg tests can be merged into exawind-driver.

@mbkuhn mbkuhn marked this pull request as ready for review June 7, 2024 20:35
@mbkuhn mbkuhn requested a review from marchdf June 10, 2024 21:18
@mbkuhn mbkuhn mentioned this pull request Jun 11, 2024
Open
14 tasks
marchdf
marchdf requested changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@marchdf marchdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Made a first pass. I probably didn't catch everything ;)

amr-wind/equation_systems/icns/icns_advection.cpp Outdated Show resolved Hide resolved
amr-wind/equation_systems/vof/volume_fractions.H Outdated Show resolved Hide resolved
amr-wind/equation_systems/vof/volume_fractions.H Outdated Show resolved Hide resolved
amr-wind/equation_systems/vof/volume_fractions.H Outdated Show resolved Hide resolved
amr-wind/equation_systems/vof/volume_fractions.H Outdated Show resolved Hide resolved
amr-wind/physics/multiphase/SloshingTank.H Outdated Show resolved Hide resolved
amr-wind/physics/multiphase/MultiPhase.cpp Outdated Show resolved Hide resolved
amr-wind/physics/multiphase/MultiPhase.cpp Show resolved Hide resolved
amr-wind/overset/overset_ops_routines.H Outdated Show resolved Hide resolved
amr-wind/overset/overset_ops_routines.H Outdated Show resolved Hide resolved
@mbkuhn
Copy link
Contributor Author

mbkuhn commented Jul 5, 2024

Marc, thanks for going through so much code here!

@mbkuhn mbkuhn merged commit 41291fe into Exawind:main Jul 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchdf marchdf marchdf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mbkuhn @marchdf