Use the RoCM/HIP device to accelerate certain DPLASMA kernels #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abouteiller
force-pushed
the
feature/hip
branch
from
012b53b
to
d8a604f
Compare
|
As discussed on 03/31/23 we need to rebase and check the result. This will be tested next week on Frontier, we need it to be ready. |
abouteiller
force-pushed
the
feature/hip
branch
2 times, most recently
from
5deec12
to
fae375c
Compare
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]> Conflicts: src/CMakeLists.txt
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
Use proper error checks instead of asserts
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
|
please squash to fewer commits. |
Signed-off-by: Aurelien Bouteiller <[email protected]>
Signed-off-by: Aurelien Bouteiller <[email protected]>
|
This is in ready to merge state beside the 'squash to less commits'. |
bosilca
reviewed
Jun 14, 2024
| @@ -109,8 +109,7 @@ extern void *dplasma_pcomm; | |||
| #define dplasma_error(__func, __msg) do { fprintf(stderr, "%s: %s\n", (__func), (__msg)); } while(0) | |||
| #endif /* defined(DPLASMA_DEBUG) */ | |||
|
|
|||
| #if defined(DPLASMA_HAVE_CUDA) | |||
| #include "dplasmaaux_cuda.h" | |||
There was a problem hiding this comment.
Why are these headers not protected ?
There was a problem hiding this comment.
protection is self contained in the header itself
There was a problem hiding this comment.
We had proper protection in place avoiding to include unnecessary files. What justify the need to made this change ?
| stage_in=stage_in_lapack | ||
| stage_out=stage_out_lapack] | ||
| stage_in=dplasma_cuda_lapack_stage_in | ||
| stage_out=dplasma_cuda_lapack_stage_out] |
There was a problem hiding this comment.
Why there is no HIP chore for the normal GEMM (aka. not the summa version) ?
There was a problem hiding this comment.
Not all kernels are implemented (tracking issue #98); those that are implemented have all of their particular variants implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds RoCM enabled kernels to the GEMM, PORTF and memory-aware GEMM operations.