OS2FRMS-11 remove permissions_by_term module and submodule #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
madsnorgaard
commented
Sep 15, 2023
•
madsnorgaard
commented
- We uninstall the modules on update if they are installed
- We remove the os2forms_permissions_by_term submodule
- We remove the permissions_by_term module form composer.json file
madsnorgaard
force-pushed
the
feature/OS2FRMS-11--remove-permissions-by-term-modules
branch
3 times, most recently
from
e862f4f
to
5865488
Compare
madsnorgaard
force-pushed
the
feature/OS2FRMS-11--remove-permissions-by-term-modules
branch
from
5865488
to
5202094
Compare
|
IF this is merged it will break out installation and handling of permissions across departments. |
|
@lilosti yes, this change was done without looking at the current context. Thus I believe we can close this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.