Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable Rocker Amplitude #1258

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Coronia
Copy link
Contributor

@Coronia Coronia commented May 9, 2024

Help TwinkleStar to finish his pull request, with proper docs this time
#1080

The rocker amplitude of warheads with Rocker=yes used to be determined by Damage value of the weapon. You can now specify it separately.

In rulesmd.ini:

[SOMEWARHEAD]       ; WarheadType
Rocker.Damage=      ; integer

Copy link
Member

@Metadorius Metadorius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No complaints about code style, probably would be better to use Nullable here tho.

src/Ext/TechnoType/Body.h Outdated Show resolved Hide resolved
Copy link
Contributor

@chaserli chaserli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently you missed the wakes for squids and crashed units.
rebase/force push the branch plz
Do not abuse sanity check when it's pointless

@Metadorius
Copy link
Member

rebase/force push the branch plz

I already merged the latest dev and fixed the build.

Copy link

github-actions bot commented May 14, 2024

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

src/Ext/TechnoType/Body.cpp Outdated Show resolved Hide resolved
@Coronia Coronia force-pushed the twinklestar-pull-request-2 branch 2 times, most recently from 0c54851 to 0f3ef3d Compare June 18, 2024 04:21
@Coronia
Copy link
Contributor Author

Coronia commented Jun 18, 2024

TwinkleStar has completed the customized wake settings for Squid parasite and sinking as well

In rulesmd.ini:

[SOMETECHNO]         ; TechnoType
Wake.Grapple=        ; Anim (played when Techno being parasited on the water), default to [General] Wake
Wake.Sinking=        ; Anim (played when Techno sinking), default to [General] Wake

@Coronia Coronia force-pushed the twinklestar-pull-request-2 branch from 0f3ef3d to e6aae50 Compare June 18, 2024 05:47
This was referenced Jul 7, 2024
@Metadorius Metadorius changed the base branch from develop to feature/wake-customization July 7, 2024 15:36
@Metadorius Metadorius deleted the branch Phobos-developers:develop July 7, 2024 16:05
@Metadorius Metadorius closed this Jul 7, 2024
@Metadorius
Copy link
Member

Took the liberty of splitting off mergeable changes and merging them with correct credit.

As for the Rocker, I think there are some improvements to be done.

[SOMEWH]                        ; WarheadType
Rocker.AmplitudeMultiplier=1.0  ; float
Rocker.FixedAmplitude=          ; integer

The first tag would multiply the regular damage if the user wants it to scale with damage, the second one would just override the damage with a fixed one. Also better naming.

@Metadorius
Copy link
Member

GH screw off, I didn't want to close this

@Metadorius Metadorius reopened this Jul 7, 2024
@Metadorius Metadorius changed the base branch from feature/wake-customization to develop July 7, 2024 16:08
@Metadorius Metadorius changed the title Customizable Rocker Amplitude & Wake Anim Customizable Rocker Amplitude Jul 7, 2024
@Metadorius Metadorius self-assigned this Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants