build(scripts): allow linting user code & lint ESM source files #1661
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb010g
force-pushed
the
build/lintModules
branch
2 times, most recently
from
063a4f5
to
a31e44e
Compare
This was referenced Aug 17, 2023
bb010g
force-pushed
the
build/lintModules
branch
from
a31e44e
to
e8f17f4
Compare
|
@Vendicated Requesting review for a pretty minor change set. The |
|
i don't think this should be added. it makes the build scripts more convoluted for no real gain and thus worsens maintainabality. these scripts are mainly useful for ci, for development you should really just set up linting inside your editor. this use case has also never come up among those who developed user plugins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR is a patch stack. Do not squash these commits.
Only//scripts/build/buildWeb.mjswas failing lint.