Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(kalman_filter): prefix package and namespace with autoware #7787

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor(kalman_filter): prefix package and namespace with autoware #7787

wants to merge 3 commits into from
+66 −41

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Jul 2, 2024

Description

prefix package and namespace with autoware

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Jul 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@esteve esteve mentioned this pull request Jul 2, 2024
Open
@esteve esteve added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 2, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.63%. Comparing base (82d86dc) to head (ff4a227).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7787      +/-   ##
==========================================
+ Coverage   28.55%   28.63%   +0.07%     
==========================================
  Files        1586     1591       +5     
  Lines      115879   116096     +217     
  Branches    49362    49491     +129     
==========================================
+ Hits        33094    33244     +150     
- Misses      73745    73771      +26     
- Partials     9040     9081      +41
Flag Coverage Δ *Carryforward flag
differential 10.51% <ø> (?)
total 28.55% <ø> (ø) Carriedforward from 82d86dc

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteve esteve changed the title refactor(kalman_fiilter): prefix package and namespace with autoware refactor(kalman_filter): prefix package and namespace with autoware Jul 2, 2024
@esteve esteve marked this pull request as ready for review July 2, 2024 12:21
@esteve esteve enabled auto-merge (squash) July 2, 2024 12:21
technolojin
technolojin reviewed Jul 3, 2024
View reviewed changes
Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the include directory topic, LGTM

@esteve esteve marked this pull request as draft July 3, 2024 08:37
auto-merge was automatically disabled July 3, 2024 08:37

Pull request was converted to draft

@esteve
Copy link
Contributor Author

esteve commented Jul 3, 2024

Back to draft to fix the issue in #7787 (comment)

@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jul 3, 2024
@esteve esteve marked this pull request as ready for review July 3, 2024 08:54
@esteve
Copy link
Contributor Author

esteve commented Jul 3, 2024

@SakodaShintaro @technolojin fixed in 8b60723

SakodaShintaro
SakodaShintaro approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that logging_simulator works well.
LGTM(for /localization)

@esteve esteve enabled auto-merge (squash) July 3, 2024 11:06
technolojin
technolojin approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@technolojin technolojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of Perception, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SakodaShintaro SakodaShintaro SakodaShintaro approved these changes

@technolojin technolojin technolojin approved these changes

@scepter914 scepter914 Awaiting requested review from scepter914 scepter914 is a code owner

@YoshiRi YoshiRi Awaiting requested review from YoshiRi YoshiRi is a code owner

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito is a code owner

@manato manato Awaiting requested review from manato manato is a code owner

@anhnv3991 anhnv3991 Awaiting requested review from anhnv3991 anhnv3991 is a code owner

@KYabuuchi KYabuuchi Awaiting requested review from KYabuuchi KYabuuchi is a code owner

@kminoda kminoda Awaiting requested review from kminoda kminoda is a code owner

@Motsu-san Motsu-san Awaiting requested review from Motsu-san Motsu-san is a code owner

@RyuYamamoto RyuYamamoto Awaiting requested review from RyuYamamoto RyuYamamoto is a code owner

@TaikiYamada4 TaikiYamada4 Awaiting requested review from TaikiYamada4 TaikiYamada4 is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@IshitaTakeshi IshitaTakeshi Awaiting requested review from IshitaTakeshi IshitaTakeshi is a code owner

@YamatoAndo YamatoAndo Awaiting requested review from YamatoAndo YamatoAndo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@esteve @SakodaShintaro @technolojin