refactor(autoware_obstacle_stop_planner): rework parameters #7795
Conversation
Signed-off-by: Ariiees <[email protected]>
Ariiees
requested review from
brkay54,
beyzanurkaya,
satoshi-ota,
shmpwk,
taikitanaka3 and
tkimura4
as code owners
github-actions
bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
mitsudome-r
added
tag:deploy-docs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7795 +/- ##
==========================================
- Coverage 28.37% 28.36% -0.01%
==========================================
Files 1584 1585 +1
Lines 115601 115622 +21
Branches 49286 49289 +3
==========================================
+ Hits 32799 32801 +2
- Misses 73845 73864 +19
Partials 8957 8957
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| "properties": { | ||
| "chattering_threshold": { | ||
| "type": "number", | ||
| "description": "INSERT_DESCRIeven if the obstacle disappears, the stop judgment continues for chattering_threshold [s]PTION", |
There was a problem hiding this comment.
| "description": "INSERT_DESCRIeven if the obstacle disappears, the stop judgment continues for chattering_threshold [s]PTION", | |
| "description": "even if the obstacle disappears, the stop judgment continues for chattering_threshold [s]", |
| "enable_slow_down": { | ||
| "type": "boolean", | ||
| "description": "whether to use slow down planner [-]", | ||
| "default": "False" |
There was a problem hiding this comment.
Could you make it to lower case?
It seems it causes some error when converting to markdown if false/true are capitalized.
| "default": "False" | |
| "default": "false" |
| "enable_z_axis_obstacle_filtering": { | ||
| "type": "boolean", | ||
| "description": "filter obstacles in z axis (height) [-]", | ||
| "default": "True" |
There was a problem hiding this comment.
Could you make it to lower case?
It seems it causes some error when converting to markdown if false/true are capitalized.
| "default": "True" | |
| "default": "true" |
| "enable_stop_behind_goal_for_obstacle": { | ||
| "type": "boolean", | ||
| "description": "enable extend trajectory after goal lane for obstacle detection", | ||
| "default": "True" |
There was a problem hiding this comment.
Could you make it to lower case?
It seems it causes some error when converting to markdown if false/true are capitalized.
| "default": "True" | |
| "default": "true" |
| "consider_constraints": { | ||
| "type": "boolean", | ||
| "description": "set 'True', if no decel plan found under jerk/dec constrains, relax target slow down vel [-]", | ||
| "default": "False" |
There was a problem hiding this comment.
Could you make it to lower case?
It seems it causes some error when converting to markdown if false/true are capitalized.
| "default": "False" | |
| "default": "false" |
| "use_predicted_objects": { | ||
| "type": "boolean", | ||
| "description": "whether to use predicted objects [-]", | ||
| "default": "False" |
There was a problem hiding this comment.
Could you make it to lower case?
It seems it causes some error when converting to markdown if false/true are capitalized.
| "default": "False" | |
| "default": "false" |
| "publish_obstacle_polygon": { | ||
| "type": "boolean", | ||
| "description": "whether to publish obstacle polygon [-]", | ||
| "default": "False" |
There was a problem hiding this comment.
Could you make it to lower case?
It seems it causes some error when converting to markdown if false/true are capitalized.
| "default": "False" | |
| "default": "false" |
| "max_slow_down_velocity": { | ||
| "type": "number", | ||
| "description": "max slow down velocity (use this param if consider_constraints is False)[m/s]", | ||
| "default": "1.38 " |
There was a problem hiding this comment.
unecessary space
| "default": "1.38 " | |
| "default": "1.38" |
Description
Implement the ROS Node configuration layout for the obstacle_stop_planner package.
Test performed
colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to autoware_obstacle_stop_plannerros2 launch autoware_obstacle_stop_planner obstacle_stop_planner.launch.xmlNotes for reviewers
None
Interface Changes
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.