Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert(stop_filter): revert "prefix package and namespace" #7818

Closed
wants to merge 1 commit into from
Closed

revert(stop_filter): revert "prefix package and namespace" #7818

wants to merge 1 commit into from

Conversation

SakodaShintaro
Copy link
Contributor

@SakodaShintaro SakodaShintaro commented Jul 4, 2024 •
edited
Loading

Description

This reverts commit fbbc44c.

I don't know the cause, but I'm reverting because the change prevents the stop_filter node from launching and /localization/kinematic_state is not output.

Related links

How was this PR tested?

  • logging_simulator
  • AWSIM + Autoware

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@SakodaShintaro SakodaShintaro added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 4, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jul 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@SakodaShintaro SakodaShintaro changed the title Revert "refactor(stop_filter): prefix package and namespace with auto… revert:(stop_filter): revert "prefix package and namespace" Jul 4, 2024
@SakodaShintaro SakodaShintaro changed the title revert:(stop_filter): revert "prefix package and namespace" revert(stop_filter): revert "prefix package and namespace" Jul 4, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.67%. Comparing base (9e47b4d) to head (c5911f3).
Report is 2 commits behind head on main.

Files Patch % Lines
localization/stop_filter/src/stop_filter.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7818      +/-   ##
==========================================
- Coverage   28.67%   28.67%   -0.01%     
==========================================
  Files        1587     1588       +1     
  Lines      116304   116324      +20     
  Branches    49656    49656              
==========================================
  Hits        33354    33354              
- Misses      73891    73911      +20     
  Partials     9059     9059
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 28.67% <ø> (ø) Carriedforward from 9e47b4d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SakodaShintaro
Copy link
Contributor Author

The bug has been fixed in the following pull request, so this pull request will be closed.
#7820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anhnv3991 anhnv3991 Awaiting requested review from anhnv3991 anhnv3991 will be requested when the pull request is marked ready for review anhnv3991 is a code owner

@KYabuuchi KYabuuchi Awaiting requested review from KYabuuchi KYabuuchi will be requested when the pull request is marked ready for review KYabuuchi is a code owner

@kminoda kminoda Awaiting requested review from kminoda kminoda will be requested when the pull request is marked ready for review kminoda is a code owner

@Motsu-san Motsu-san Awaiting requested review from Motsu-san Motsu-san will be requested when the pull request is marked ready for review Motsu-san is a code owner

@RyuYamamoto RyuYamamoto Awaiting requested review from RyuYamamoto RyuYamamoto will be requested when the pull request is marked ready for review RyuYamamoto is a code owner

@TaikiYamada4 TaikiYamada4 Awaiting requested review from TaikiYamada4 TaikiYamada4 will be requested when the pull request is marked ready for review TaikiYamada4 is a code owner

@YamatoAndo YamatoAndo Awaiting requested review from YamatoAndo YamatoAndo will be requested when the pull request is marked ready for review YamatoAndo is a code owner

Assignees
No one assigned
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@SakodaShintaro