Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(probabilistic_occupancy_grid_map)!: fix namespace and directory structure #7872

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Jul 5, 2024

Description

This PR puts headers in the autoware namespace.

Additional works

  1. Align directory structure to follow the coding guidelines.
  2. Clean unused dependencies LIST

Related links

Part of: autowarefoundation/autoware#4569

How was this PR tested?

Tested in a local recompute environment and the TIER IV Cloud environment.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jul 5, 2024
Copy link

github-actions bot commented Jul 5, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin marked this pull request as ready for review July 8, 2024 05:06
@technolojin technolojin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 27.50000% with 29 lines in your changes missing coverage. Please review.

Project coverage is 28.71%. Comparing base (b233929) to head (5bc0b89).
Report is 23 commits behind head on main.

Files Patch % Lines
...id_map/lib/costmap_2d/occupancy_grid_map_fixed.cpp 12.50% 7 Missing ⚠️
...ncy_grid_map/lib/costmap_2d/occupancy_grid_map.cpp 0.00% 5 Missing ⚠️
...p/lib/costmap_2d/occupancy_grid_map_projective.cpp 0.00% 5 Missing ⚠️
...obabilistic_occupancy_grid_map/lib/utils/utils.cpp 0.00% 3 Missing ⚠️
...obabilistic_occupancy_grid_map/test/test_utils.cpp 0.00% 0 Missing and 3 partials ⚠️
...pancy_grid_map/lib/fusion_policy/fusion_policy.cpp 0.00% 0 Missing and 2 partials ⚠️
...id_map/laserscan_based_occupancy_grid_map_node.cpp 0.00% 2 Missing ⚠️
...id_map/lib/updater/binary_bayes_filter_updater.cpp 66.66% 0 Missing and 1 partial ⚠️
...p/src/fusion/synchronized_grid_map_fusion_node.cpp 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7872      +/-   ##
==========================================
+ Coverage   28.66%   28.71%   +0.04%     
==========================================
  Files        1588     1602      +14     
  Lines      116375   116988     +613     
  Branches    49696    49956     +260     
==========================================
+ Hits        33358    33591     +233     
- Misses      73925    74275     +350     
- Partials     9092     9122      +30     
Flag Coverage Δ *Carryforward flag
differential 10.66% <27.50%> (?)
total 28.66% <ø> (-0.01%) ⬇️ Carriedforward from cd0f68c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin merged commit 45a0c3a into autowarefoundation:main Jul 8, 2024
29 of 30 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jul 8, 2024
…ory structure (autowarefoundation#7872)

* refactor: update include paths for probabilistic occupancy grid map

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: update include paths for probabilistic occupancy grid map

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: update namespace for nodes

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: update namespace for lib

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: remove unused dependency

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: use const pointer for occupancy grid map data

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
@technolojin technolojin deleted the refactor/namespace-probabilistic_occupancy_grid_map branch July 9, 2024 04:05
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
…ory structure (autowarefoundation#7872)

* refactor: update include paths for probabilistic occupancy grid map

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: update include paths for probabilistic occupancy grid map

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: update namespace for nodes

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: update namespace for lib

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: remove unused dependency

Signed-off-by: Taekjin LEE <[email protected]>

* refactor: use const pointer for occupancy grid map data

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: palas21 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants