ID-1327 revert synchronous group removals and refactor #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ghost-in-a-Jar
approved these changes
Jul 8, 2024
dvoet
approved these changes
Jul 8, 2024
Ghost-in-a-Jar
requested changes
Jul 8, 2024
|
@Ghost-in-a-Jar done |
Ghost-in-a-Jar
approved these changes
Jul 8, 2024
okotsopoulos
reviewed
Jul 8, 2024
There was a problem hiding this comment.
Thanks! I left a few suggestions for test improvement.
Now that google group synchronization is fixed, its no longer needed.
I'm probably out of the loop here, is there somewhere I can go to learn more about how Google Group synchronization was fixed (ex. an incident review page)?
src/test/scala/org/broadinstitute/dsde/workbench/sam/google/GoogleExtensionRoutesSpec.scala
Outdated
Show resolved
Hide resolved
src/test/scala/org/broadinstitute/dsde/workbench/sam/google/GoogleExtensionRoutesSpec.scala
Outdated
Show resolved
Hide resolved
okotsopoulos
approved these changes
Jul 8, 2024
|
tlangs
deleted the
tl_ID-1327_revert_synchronous_group_removals_and_refactor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/ID-1327
Reverting the synchronous group sync for policy removals. This was a band-aid, but has the potential to create long request latencies. Now that google group synchronization is fixed, its no longer needed.
Also did a little refactor of the sync de-duplication. Instead of relying on an exception for control flow, we now rely on an
Option. This is best-practice, since using exceptions for control flow incurs a significant performance penalty in JVM languages.PR checklist