Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make catalogue a dev-only requirement #35

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Make catalogue a dev-only requirement #35

merged 2 commits into from
Jul 3, 2023

Conversation

adrianeboyd
Copy link
Contributor

No description provided.

rmitsch
rmitsch approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@rmitsch rmitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a snippet in the readme referring to catalogue - maybe we should add a comment stating that it's not installed by default now?

@adrianeboyd
Copy link
Contributor Author

Good suggestion, do you think this is enough?

@rmitsch
Copy link
Contributor

rmitsch commented Jul 3, 2023

I think that's fine.

@adrianeboyd adrianeboyd merged commit a8823dd into explosion:main Jul 3, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmitsch rmitsch rmitsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adrianeboyd @rmitsch