Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make catalogue a dev-only requirement #35

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Make catalogue a dev-only requirement #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92063c9
Make catalogue a dev-only requirement
adrianeboyd Jun 29, 2023
9cbea17
Add note about installing catalogue to README
adrianeboyd Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@ learn_rate = 0.001
gamma = 1e-8
```

To load and parse this configuration:
To load and parse this configuration using a `catalogue` registry (install
[`catalogue`](https://github.com/explosion/catalogue) separately):

```python
import dataclasses
Expand Down
1 change: 0 additions & 1 deletion confection/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
from pydantic.main import ModelMetaclass
from pydantic.fields import ModelField
import srsly
import catalogue
import inspect
import io
import copy
Expand Down
1 change: 1 addition & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ pydantic>=1.7.4,!=1.8,!=1.8.1,<1.11.0
typing_extensions>=3.7.4.1,<4.5.0; python_version < "3.8"
srsly>=2.4.0,<3.0.0
# Development requirements
catalogue>=2.0.3,<2.1.0
pathy>=0.3.5
pytest>=5.2.0,!=7.1.0
mypy>=0.980,<0.990; platform_machine != 'aarch64' and python_version >= '3.7'
Expand Down