Merge manuscript branch #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vant tools did not exist at that time
Bisaloo
requested changes
Feb 16, 2023
There was a problem hiding this comment.
I'm not sure the manuscript itself needs to be included. What about just linking to the paper as suggested in #73?
I also wouldn't include the benchmark RDS files. Since they were long & difficult to generate, it may indeed to worth saving save somewhere though. I'm just not sure where. As release artifacts?
Said differently, I would just add the benchmarking scripts.
In any case, this PR will require changes in .Rbuildignore before merging.
|
See #82 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the paper is published 🎉 we could merge this branch in the main one, right?
So the manuscript and benchmarks are all together with the package.
Is it necessarily distributed whenever people download the package?