Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark scripts and template #82

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Rekyt
Copy link
Member

@Rekyt Rekyt commented Dec 2, 2023

Add the benchmark scripts used for the manuscript in inst/ folder in order to keep in the main repo instead of merging the full manuscript as suggested in #72

@Rekyt Rekyt requested a review from Bisaloo December 2, 2023 08:20
@Rekyt Rekyt mentioned this pull request Dec 2, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3767b7b) 100.00% compared to head (fbbe2cf) 100.00%.
Report is 5 commits behind head on main.

❗ Current head fbbe2cf differs from pull request most recent head e27a46b. Consider uploading reports for the commit e27a46b to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #82   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          257       257           
=========================================
  Hits           257       257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Bisaloo Bisaloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's looking good. Should we provide a renv.lock lockfile alongside it to ensure easier reproducibility?

I'm on the fence because we want to take into account updates to the packages we're comparing fundiversity to. But I'm afraid that updates to, e.g., rlang may be slightly annoying to diagnose and take into account if we want to re-run this script.

On the other hand, having renv.lock doesn't mean we have to use it. It can also serve as a session info to help in diagnosing what is preventing reproducibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants