Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duwi brand #5491

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

duwi2024
Copy link

@duwi2024 duwi2024 commented May 23, 2024

Proposed change

Submitted some necessary images to the newly added integration: duwi

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow the original PR template got lost when you made this PR and replaced it with something completely different.

Please restore the original PR template and fill it out.

Thanks! 👍

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@klaasnicolaas klaasnicolaas marked this pull request as draft May 23, 2024 07:44
@klaasnicolaas
Copy link
Member

Remarked as draft PR as the PR description template has still not been restored.

./Klaas

@duwi2024 duwi2024 marked this pull request as ready for review May 24, 2024 07:56
@frenck frenck added the has-parent This PR has a parent PR in a other repo label May 24, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@Ledgerbiggg
Copy link

@frenck Thanks for the approval, awaiting the merge!😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants