Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duwi integration #118012

Open
wants to merge 17 commits into
base: dev
Choose a base branch
from
Open

Conversation

duwi2024
Copy link

@duwi2024 duwi2024 commented May 24, 2024

Breaking change

This update does not introduce any breaking changes as it's the addition of a new integration with Home Assistant. Current users can continue to use their setups without any modifications; however, they should be aware that the integration leverages a new SDK (duwi-smarthome-sdk) to communicate with Duwi devices.

Proposed change

By summarizing the latest enhancements and underlying SDK updates, this proposed change underscores our commitment to improving home automation through continuous innovation. We believe these developments strengthen our offering, making a compelling case for the inclusion of this updated Duwi Integration in the Home Assistant platform.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Ledgerbiggg and others added 4 commits May 21, 2024 11:07
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@home-assistant home-assistant bot marked this pull request as draft May 24, 2024 05:54
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@duwi2024 duwi2024 marked this pull request as ready for review May 24, 2024 05:54
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains three platforms (light, cover, switch). Please limit the initial addition of a new integration to a single platform. Additional platforms can be added in follow up PRs.

../Frenck

@home-assistant home-assistant bot marked this pull request as draft May 24, 2024 08:17
Following Home Assistant's contribution guidelines, this commit limits the initial addition of the new duwi integration to the switch platform only. Additional platforms (cover, light) to be added in subsequent PRs as recommended.
home-assistant[bot]

This comment was marked as resolved.

duwi2024 and others added 4 commits May 27, 2024 11:11
# Conflicts:
#	homeassistant/components/duwi/const.py
#	homeassistant/components/duwi/cover.py
#	homeassistant/components/duwi/light.py
#	homeassistant/components/duwi/manifest.json
chore(duwi): Remove Cover and Light from duwi integration
@duwi2024 duwi2024 marked this pull request as ready for review May 27, 2024 05:11
@home-assistant home-assistant bot requested a review from frenck May 27, 2024 05:11
@Ledgerbiggg
Copy link

@frenck I've made the requested changes. Could you please take another look when you have a moment? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants