-
-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add duwi integration #118012
base: dev
Are you sure you want to change the base?
Add duwi integration #118012
Conversation
- Add support for Duwi devices in Home Assistant. - Ensure compatibility and testing completed.
Add duwi integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Add the version number of the new integrated duwi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains three platforms (light, cover, switch). Please limit the initial addition of a new integration to a single platform. Additional platforms can be added in follow up PRs.
../Frenck
Following Home Assistant's contribution guidelines, this commit limits the initial addition of the new duwi integration to the switch platform only. Additional platforms (cover, light) to be added in subsequent PRs as recommended.
dc35f0b
to
180e9e2
Compare
# Conflicts: # homeassistant/components/duwi/const.py # homeassistant/components/duwi/cover.py # homeassistant/components/duwi/light.py # homeassistant/components/duwi/manifest.json
chore(duwi): Remove Cover and Light from duwi integration
@frenck I've made the requested changes. Could you please take another look when you have a moment? Thank you! |
Breaking change
This update does not introduce any breaking changes as it's the addition of a new integration with Home Assistant. Current users can continue to use their setups without any modifications; however, they should be aware that the integration leverages a new SDK (duwi-smarthome-sdk) to communicate with Duwi devices.
Proposed change
By summarizing the latest enhancements and underlying SDK updates, this proposed change underscores our commitment to improving home automation through continuous innovation. We believe these developments strengthen our offering, making a compelling case for the inclusion of this updated Duwi Integration in the Home Assistant platform.
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: