Product: Make tooltips visible to screen readers #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the shipping restriction and returns notice visible to screen readers. Also adds aria label text to each. This is similar to what we do for the prop 65 warning Chakra's docs recommend that the popover trigger be focusable, hence the use of IconButton. https://chakra-ui.com/docs/components/popover/usage#basic-usage
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
masonmcelvain
changed the title
masonmcelvain
changed the title
📦 Next.js Bundle Analysis for @ifixit/commerce-frontendThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
QA 🟢 The shipping restriction and 30 day returns ℹ️ button tooltips are being read by screen readers 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/iFixit/ifixit/issues/51384
Makes the shipping restriction and returns notice visible to screen readers. Also adds aria label text to each.
This is similar to what we do for the prop 65 warning.
Chakra's docs recommend that the popover trigger be focusable, hence the use of IconButton. https://chakra-ui.com/docs/components/popover/usage#basic-usage
QA
Visit the Vercel preview and make sure that the shipping restrictions and returns info buttons are not skipped by screen readers.