Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product: Make tooltips visible to screen readers #2212

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Product: Make tooltips visible to screen readers #2212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions ...tend/templates/product/sections/ProductOverviewSection/AddToCart/ShippingRestrictions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Box, Flex, StackProps, VStack } from '@chakra-ui/react';
import { Box, Flex, IconButton, StackProps, VStack } from '@chakra-ui/react';
import { Tooltip } from '@components/ui/Tooltip';
import { faCircleInfo } from '@fortawesome/pro-solid-svg-icons';
import { FaIcon } from '@ifixit/icons';
Expand Down Expand Up @@ -73,12 +73,18 @@ export function ShippingRestrictions({
{shippingRestriction.notice}
<Tooltip
trigger={
<FaIcon
icon={faCircleInfo}
h="4"
mt="1px"
ml="1.5"
color="gray.400"
<IconButton
aria-label="Learn more about this shipping restriction"
ml="1"
size="sm"
variant="ghost"
icon={
<FaIcon
icon={faCircleInfo}
h="4"
color="gray.400"
/>
}
/>
}
content={
Expand Down
16 changes: 9 additions & 7 deletions frontend/templates/product/sections/ProductOverviewSection/ValuePropositionList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Box, List, ListIcon, ListItem } from '@chakra-ui/react';
import { Box, IconButton, List, ListIcon, ListItem } from '@chakra-ui/react';
import { Tooltip } from '@components/ui/Tooltip';
import {
faBadgeDollar,
Expand Down Expand Up @@ -62,12 +62,14 @@ export function ValuePropositionList() {
<div>30-day returns</div>
<Tooltip
trigger={
<FaIcon
icon={faCircleInfo}
h="4"
mt="1px"
ml="1.5"
color="gray.400"
<IconButton
aria-label="Learn more about our return policy"
ml="1"
size="sm"
variant="ghost"
icon={
<FaIcon icon={faCircleInfo} h="4" color="gray.400" />
}
/>
}
content={
Expand Down