Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hit formatting of diemodel input files #130

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

apb13
Copy link
Contributor

@apb13 apb13 commented Jun 24, 2024

Reason

Update input files to align with current hit formatting standards in MOOSE.

Design

Use script capabilities in MOOSE to update hit formatting.

Impact

Increased input file consistency and usability.

@apb13 apb13 changed the title hit formatting of diemodel input files Refs #128 hit formatting of diemodel input files Jun 24, 2024
@apb13
Copy link
Contributor Author

apb13 commented Jun 24, 2024

Performed comparison between the two csv files, one that was the original and another that received hit formatting, to ensure that the results were the same. Also ensured that comments were formatted correctly in the input file.
Refs #128

@moosebuild
Copy link

Job Documentation on d0a7328 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link

Job Coverage on d0a7328 wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

@cticenhour
Copy link
Member

@apb13 FYI - prior comments made by you can be edited (with version control!). So if you needed to edit the original post, as in this case, you can simply click on the "three dots" on the upper right of any GitHub comment and you'll get the following panel:
image

Then click on "Edit" to edit the post and click the "Update Comment" button to save!

image

Just to be clear, you don't need to do this for this PR. I just wanted to share some GitHub tips and tricks for your future PRs!

@sapitts
Copy link
Collaborator

sapitts commented Jun 24, 2024

@cticenhour do you know what is going on with the Mac test for this PR by chance?

@cticenhour
Copy link
Member

We only have a handful of "darwin-clang" (AKA Intel Mac) clients now that the Mac trashcans are no more, so it's likely just busy in the queue.

@sapitts sapitts requested a review from cticenhour June 24, 2024 22:54
@cticenhour cticenhour merged commit 23d9464 into idaholab:devel Jun 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants