Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to notes being customised #782

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Add support to notes being customised #782

wants to merge 4 commits into from

Conversation

Sae126V
Copy link
Contributor

@Sae126V Sae126V commented Jun 6, 2024

No description provided.

@Sae126V Sae126V marked this pull request as ready for review June 6, 2024 07:29
@Sae126V Sae126V modified the milestone: v1.8.3 Jun 6, 2024
@Sae126V Sae126V force-pushed the issue-759-registration-ui branch from 185b3d4 to e8a18f5 Compare June 7, 2024 06:47
@Sae126V Sae126V self-assigned this Jun 7, 2024
@enricovianello enricovianello linked an issue Jun 14, 2024 that may be closed by this pull request
User registration form "Notes" field usability issue #759
Open
@rmiccoli
Copy link
Contributor

Perhaps we can put an if statement in the email template (adminHandleRequest.ftl) so that notes are only shown if the content is not empty.
e.g.

<#if notes?has_content>
Notes:
${notes}
</#if>

@Sae126V
Copy link
Contributor Author

Sae126V commented Jul 4, 2024

Perhaps we can put an if statement in the email template (adminHandleRequest.ftl) so that notes are only shown if the content is not empty. e.g.

<#if notes?has_content>
Notes:
${notes}
</#if>

Ahh! You are right @rmiccoli 👍 . Added in 14800ca

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enricovianello enricovianello Awaiting requested review from enricovianello

@federicaagostini federicaagostini Awaiting requested review from federicaagostini

@rmiccoli rmiccoli Awaiting requested review from rmiccoli

@garaimanoj garaimanoj Awaiting requested review from garaimanoj

At least 1 approving review is required to merge this pull request.

Assignees

@Sae126V Sae126V

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User registration form "Notes" field usability issue
2 participants
@Sae126V @rmiccoli