Add keystone support #12
Conversation
Add keystone support
|
@thousandsofthem @pyeremenko could you please review |
| @@ -421,6 +443,32 @@ protected function setCommonHeaders() | |||
| 'Keep-Alive' => '300' | |||
| ); | |||
| } | |||
|
|
|||
| protected function getToken() | |||
There was a problem hiding this comment.
I can't find any call of getToken :(
There was a problem hiding this comment.
it's there - https://github.com/iron-io/iron_mq_php/pull/38/files
There was a problem hiding this comment.
Oh, sorry, it's iron_core
|
@thousandsofthem, please, look at this PR. I think it could be merged. |
|
|
||
| $req = array( | ||
| 'auth' => array( | ||
| 'tenantName' => $this->keystone['tenant'], |
There was a problem hiding this comment.
tenantId as far as I understand how it works , names are not reliable
There was a problem hiding this comment.
@thousandsofthem, could you clarify?
There was a problem hiding this comment.
This one works for sure, using it in HUD-e:
https://github.com/iron-io/iron_core_ruby/blob/master/lib/iron_core/keystone_token_provider.rb#L16
There was a problem hiding this comment.
P.S. Also, tenantId always equal to project_id so could be derived from it
P.P.S. tenantName is not unique therefore can't be used as a key
There was a problem hiding this comment.
- @edsrzf said we should support not tenantId, but tenantName, please discuss it with him.
- Why 'tenantName' string is not unique key?
There was a problem hiding this comment.
tenantName means "project name", and user can set any name he wants to, including duplicate ones.
@edsrzf do you know anything else?
There was a problem hiding this comment.
Some notes:
- only project_id required (with
tenantId), project name is extra dependency tenantIdactually works with test server and on AT&T installation
There was a problem hiding this comment.
any update so far?
There was a problem hiding this comment.
We implemented support of format "keystone": { "server": ..., "tenant": ..., "username": ..., "password": ... } because we discussed it with Evan and he accepted this way. @thousandsofthem wants to change this format and we will change it if somebody of you confirm it.
|
I know this is WIP but it's out of sync with https://github.com/iron-io/iron_mq_php/tree/v3 Perhaps a note in the Specific issue is |
No description provided.