Fixed endless refresh loop #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With initial code page ended up in endless refresh loop. Added flags to stop that. Also added flags clearing in case user navigates to other page and back. Finally fixed an edge case when no form was returned in case user had a organization assigned with tags, but none of the tags was actual form ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With initial code page ended up in endless refresh loop. Added flags to stop that.
Also added flags clearing in case user navigates to other page and back. Finally fixed an edge case when no form was returned in case user had a organization assigned with tags, but none of the tags was actual form ID.
Thanks for sharing your code that helped a lot 🙏