add bits_to_target

[harsh-ps-2003]

• issue Implement bits_to_target Function #9
• follows contribution guide
• code change includes tests

Adds bits_to_target with a custom power method of u256, and uses it to validate_target

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
raito	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 8, 2024 1:42am

[maciejka]

Where are the test cases?

[harsh-ps-2003]

Where are the test cases?

Will be adding them later today most probably! Suddenly got busy with some work! Thanks for the patience

Edit: Sorry, will try finishing this weekend @maciejka

[maciejka]

Where are the test cases?

Will be adding them later today most probably! Suddenly got busy with some work! Thanks for the patience

Edit: Sorry, will try finishing this weekend @maciejka Need a relaxation break from OSS, mental health stuff. But don't worry, I will finish things up!

No problem, I am not trying to push you. Just thought, since you requested a review, that maybe you have forgotten to add test files to the commit.

Definitely get some rest.

[maciejka]

Please squash prs #15 and #16.

[maciejka]

How are you? Is there any progress? There are other issues waiting for this one to finish...

[maciejka]

Resolve conflicts, please.

[maciejka]

Fix fmt and tests, please.

[maciejka]

@maciejka suddenly I get error

Error: `scarb metadata` exited with error

stdout:
error: failed to lookup for `cairo_test ^2.7.0` in registry: registry+https://there-is-no-default-registry-yet.com/

when trying to run scarb test locally!

Please ask on scarb tg channel: https://t.me/+1pMLtrNj5NthZWJk

[maciejka]

@harsh-ps-2003 please fix conflicts

[harsh-ps-2003]

Thanks for the patience! @maciejka