-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve convertion errors and handle invalid ABI #387
Open
whichqua
wants to merge
9
commits into
main
Choose a base branch
from
gm/no-possible-convertion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
shamsasari
reviewed
Sep 27, 2024
shamsasari
reviewed
Sep 27, 2024
shamsasari
reviewed
Sep 27, 2024
HermanObst
reviewed
Sep 27, 2024
HermanObst
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
notlesh
reviewed
Oct 1, 2024
notlesh
approved these changes
Oct 1, 2024
@whichqua please address @shamsasari comments before merging |
* fix: handle contract commitments for contract without data items Problem: reexecution panics when a contract doesnt have data items Solution: handle the edge case to prevent panics * fix: only one commitment return
HermanObst
requested changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This need further investigation in PAthfinder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: During convertions between types from blockifier, starknet and cairolang classes, the errors returned are not consistent. This also led to finding an invalid api bug during convertion.
Solution:
ConvertionError
andRpcClientError
and handle them appropriately.None
when abi is not valid JSON.Issue Number: N/A
Type
Description
Breaking changes?