Publish API used by luasec #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
This is a quite large pull request and it deserves some explanation. It is one of two pull requests (the second one going to luasec) which shall fix the issue of duplication of code in luasocket and luasec and the issues which arise from using a dynamically linked version of luasec (see also Prosody bug #28).
The first commit publishes the WAITFD_* constants, which are used by luasec at some places and is part of the modifications luasec makes to the luasocket headers.
The second one is larger and possibly more disputable. It publishes a whole bunch, probably more than strictly needed, of functions using the LUASOCKET_API define. This is required to allow luasec to find the symbols if loaded into the same process.
Together with the pull request which will be issued in a minute to luasec, this could improve user experience, especially on redhat systems, where the libraries are dynamically linked, a lot.
If you have any suggestions for improvements or any kind of critique, please let me know so that we can fix that quickly.
best regards,
Jonas