fix: named exports for v5 compatibility #292
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change from module.exports to export default no longer allows you to use named imports. This would be a breaking change, but it's also incompatible with the current type declarations. This could be fixed using commonjs module and 'export =' in TypeScript, but this is incompatible with Rollup. The simplest answer seems to be just explicitly using named exports based on the type declarations as well as including the default export.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change from module.exports to export default no longer allows you to use named imports. This would be a breaking change, but it's also incompatible with the current type declarations.
This could be fixed using commonjs module and 'export =' in TypeScript, but this is incompatible with Rollup. The simplest answer seems to be just explicitly using named exports based on the type declarations as well as including the default export.
Fixes #291