[#27712] PowerToys New+ v0.1 - Very early prelease version #33136

cgaarden · 2024-05-29T03:46:09Z

Summary of the Pull Request

This PR contains an attempt of a first very prelease early version of New+ (#27712)

New+ is a new PowerToys for the File Explorer that enables users to create files and folders from a personalized set of templates.

Issue:
#27712

Spec:
https://1drv.ms/w/s!AgfnseFPEL1w2NklIIJb2hDgHkz6MQ?e=b8rSuL

This PR includes:
• Very early version of New+
• New+ Windows 11 File Explorer support
• Dark and Light System Theme support
• Logging + Trace
• New+ GPO settings
• New+ Settings page
• New+ What's new page
• New+ uninstall support

Closes: Create new file from a list of customizable templates straight from the folder context menu #27712
This doesn’t close Create new file from a list of customizable templates straight from the folder context menu #27712 yet
Communication: I've discussed this with core contributors already.
Tests: Added/updated and all pass
Localization: All end user facing strings can be localized
Dev docs: Added/updated

Any dev docs that needs to be added in PowerToys repo? I can move the .docx spec to .md.
Note: I expect that I will need to add to https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys

New binaries: Added on the required places
- JSON for signing for new binaries
- WXS for installer for new binaries and localization folder

Installer not yet completed

YML for CI pipeline for new test projects

No new test projects yet

YML for signed pipeline

Don't think any changes are required

Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Haven't added documentation yet

Detailed Description of the Pull Request / Additional comments

• Added System Theme to ThemeHelper.h/.cpp and renamed AppTheme enum to Theme

Validation Steps Performed

• Ran all unit tests except for UITests-FancyZones, UITests-FancyZonesEditor
• Removed all default settings
• Tested that defaults are same via Settings or just via invoking File Extension for the first time
• Removed new+ template folder
• Removed all items in new+ template folder
• Changed template folder location via settings 
• Changed hide extension via settings
• Changed dark and light system themes
• Basic test of Keyboard manager with different app theme
• Basic test of PowerRename with different app theme
• Toggling New+ via GPO settings

Made ThemeRegistryHelper protected

Removed New.wxs from installer

Restored logger_helper.h

Updated resources to have the right white space formatting

Replaced tabs with spaces

Added GPO info to GPO assets and fixed bug while testing GPO support

Added files for signing

htcfreek

Thank you for the contribution.

I made a small comment on the policy name.

htcfreek · 2024-05-29T04:51:21Z

src/gpo/assets/PowerToys.admx

@@ -326,6 +327,16 @@
        <decimal value="0" />
      </disabledValue>
    </policy>
+    <policy name="ConfigureEnabledUtilityNew" class="Both" displayName="$(string.ConfigureEnabledUtilityNew)" explainText="$(string.ConfigureEnabledUtilityDescription)" key="Software\Policies\PowerToys" valueName="ConfigureEnabledUtilityNew">


I know it's early state. And maybe you don't like to use the character +. But only new can be confusing and interpreted as adjective. So we should use NewPlus as utility name.

Thank you @htcfreek! I've changed it to ConfigureEnabledUtilityNewPlus

cgaarden · 2024-05-29T23:40:44Z

@microsoft-github-policy-service agree

…ddress feedback from htcfreak Update GPO setting name to reference NewPlus rather than just New - Address feedback from htcfreak

using git-bash curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' | perl - 'https://github.com/microsoft/PowerToys/actions/runs/9294625751/attempts/1'

htcfreek

I think it's the best to rename all places (docs, code, directory, installer) where the utility is called "New" to "NewPlus".

New can be read as new item and is confusing then.

htcfreek · 2024-05-30T06:19:17Z

src/common/ManagedCommon/ModuleType.cs

@@ -30,5 +30,6 @@ public enum ModuleType
        MeasureTool,
        ShortcutGuide,
        PowerOCR,
+        New,


The same as on the policy name. This is confusing. Please rename to NewPlus.

The same as on the policy name. This is confusing. Please rename to NewPlus.

Thank you! I've finally gotten around to renaming to NewPlus throughout. Thanks again.

htcfreek · 2024-05-30T06:20:28Z

src/common/GPOWrapper/GPOWrapper.cpp

@@ -176,4 +176,8 @@ namespace winrt::PowerToys::GPOWrapper::implementation
    {
        return static_cast<GpoRuleConfigured>(powertoys_gpo::getAllowedAdvancedPasteOnlineAIModelsValue());
    }
+    GpoRuleConfigured GPOWrapper::GetConfiguredNewEnabledValue()


The same as on the policy name. This is confusing. Please rename to NewPlus.

Thank you! I've finally gotten around to renaming to NewPlus throughout. Thanks again.

htcfreek · 2024-05-30T06:21:02Z

src/common/utils/gpo.h

@@ -475,4 +476,9 @@ namespace powertoys_gpo {
    {
        return getUtilityEnabledValue(POLICY_ALLOW_ADVANCED_PASTE_ONLINE_AI_MODELS);
    }
+
+    inline gpo_rule_configured_t getConfiguredNewEnabledValue()


The same as on the policy name. This is confusing. Please rename to NewPlus.

Thank you! I've finally gotten around to renaming to NewPlus throughout. Thanks again.

htcfreek · 2024-05-30T06:21:19Z

src/common/utils/gpo.h

@@ -59,6 +59,7 @@ namespace powertoys_gpo {
    const std::wstring POLICY_CONFIGURE_ENABLED_ENVIRONMENT_VARIABLES = L"ConfigureEnabledUtilityEnvironmentVariables";
    const std::wstring POLICY_CONFIGURE_ENABLED_QOI_PREVIEW = L"ConfigureEnabledUtilityFileExplorerQOIPreview";
    const std::wstring POLICY_CONFIGURE_ENABLED_QOI_THUMBNAILS = L"ConfigureEnabledUtilityFileExplorerQOIThumbnails";
+    const std::wstring POLICY_CONFIGURE_ENABLED_NEW = L"ConfigureEnabledUtilityNewPlus";


The same as on the policy name. This is confusing. Please rename to NewPlus.

Thank you! I've finally gotten around to renaming to NewPlus throughout. Thanks again.

Not fully tested

…into NewPlus-v0.1

…yet)

cgaarden added 13 commits May 26, 2024 13:58

Very early v0.1 of New+

71dfed2

Merge branch 'main' into NewPlus-v0.1

fc2f58d

Update PowerToysInstaller.wixproj

81039dc

Restore installer

35b7ee1

Update theme_helpers.h

db932c3

Made ThemeRegistryHelper protected

Delete New.wxs

6ef1a3f

Removed New.wxs from installer

Update logger_helper.h

5490c65

Restored logger_helper.h

Removing unintended changes after merge

bae2a19

Update Resources.resw

9d951d1

Updated resources to have the right white space formatting

Update Resources.resw

19c5197

Replaced tabs with spaces

Fixed GPO support

27e064f

Added GPO info to GPO assets and fixed bug while testing GPO support

Update ESRPSigning_core.json

738e926

Added files for signing

Removed clang-format

dbff411

cgaarden requested review from crutkas, DHowett and ethanfangg as code owners May 29, 2024 03:46

cgaarden marked this pull request as draft May 29, 2024 03:46

This comment has been minimized.

Sign in to view

htcfreek reviewed May 29, 2024

View reviewed changes

Update GPO setting name to reference NewPlus rather than just New - A…

af738db

…ddress feedback from htcfreak Update GPO setting name to reference NewPlus rather than just New - Address feedback from htcfreak

This comment has been minimized.

Sign in to view

Added additional words to expect.txt

0e42492

using git-bash curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' | perl - 'https://github.com/microsoft/PowerToys/actions/runs/9294625751/attempts/1'

htcfreek reviewed May 30, 2024

View reviewed changes

Jay-o-Way added the Idea-New PowerToy Suggestion for a PowerToy label Jun 2, 2024

cgaarden added 5 commits June 7, 2024 23:28

Initial Installer Changes

c33a84c

Not fully tested

Fixed installer of New+

a72529b

Removed non-used constant and catch if failing to load json state

07e8174

New+ should be disabled by default

cd91840

Merge remote-tracking branch 'upstream/main' into NewPlus-v0.1

2bb29b3

cgaarden added 3 commits June 27, 2024 21:29

Added a couple of examples templates to the project

985b50a

Merge branch 'NewPlus-v0.1' of https://github.com/cgaarden/PowerToys …

0bff942

…into NewPlus-v0.1

Merge remote-tracking branch 'upstream/main' into NewPlus-v0.1

a9faa1c

This comment has been minimized.

Sign in to view

cgaarden added 2 commits June 29, 2024 09:45

Updated example templates and initial work on installer (not working …

adf1254

…yet)

Made example templates installable

b98dd4d

This comment has been minimized.

Sign in to view

Updated installer to install NewPlus Example Templates

c994257

This comment has been minimized.

Sign in to view

Renamed New to NewPlus throughout

5e81c76

This comment has been minimized.

Sign in to view

cgaarden added 2 commits June 30, 2024 14:15

Fixed spelling error

5af3cb7

Additional NewPlus renaming

7cb88c5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#27712] PowerToys New+ v0.1 - Very early prelease version #33136

[#27712] PowerToys New+ v0.1 - Very early prelease version #33136

cgaarden commented May 29, 2024 •

edited by Aaron-Junker

Loading

This comment has been minimized.

htcfreek left a comment

htcfreek May 29, 2024

cgaarden May 29, 2024

cgaarden commented May 29, 2024

This comment has been minimized.

htcfreek left a comment

htcfreek May 30, 2024

cgaarden Jun 30, 2024

htcfreek May 30, 2024

cgaarden Jun 30, 2024

htcfreek May 30, 2024

cgaarden Jun 30, 2024

htcfreek May 30, 2024

cgaarden Jun 30, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

[#27712] PowerToys New+ v0.1 - Very early prelease version #33136

Are you sure you want to change the base?

[#27712] PowerToys New+ v0.1 - Very early prelease version #33136

Conversation

cgaarden commented May 29, 2024 • edited by Aaron-Junker Loading

Summary of the Pull Request

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

This comment has been minimized.

htcfreek left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cgaarden commented May 29, 2024

This comment has been minimized.

htcfreek left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cgaarden commented May 29, 2024 •

edited by Aaron-Junker

Loading