Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#27712] PowerToys New+ v0.1 - Very early prelease version #33136

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

[#27712] PowerToys New+ v0.1 - Very early prelease version #33136

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
71dfed2
Very early v0.1 of New+
cgaarden May 16, 2024
fc2f58d
Merge branch 'main' into NewPlus-v0.1
cgaarden May 27, 2024
81039dc
Update PowerToysInstaller.wixproj
cgaarden May 27, 2024
35b7ee1
Restore installer
cgaarden May 28, 2024
db932c3
Update theme_helpers.h
cgaarden May 29, 2024
6ef1a3f
Delete New.wxs
cgaarden May 29, 2024
5490c65
Update logger_helper.h
cgaarden May 29, 2024
bae2a19
Removing unintended changes after merge
cgaarden May 29, 2024
9d951d1
Update Resources.resw
cgaarden May 29, 2024
19c5197
Update Resources.resw
cgaarden May 29, 2024
27e064f
Fixed GPO support
cgaarden May 29, 2024
738e926
Update ESRPSigning_core.json
cgaarden May 29, 2024
dbff411
Removed clang-format
cgaarden May 29, 2024
af738db
Update GPO setting name to reference NewPlus rather than just New - A…
cgaarden May 29, 2024
0e42492
Added additional words to expect.txt
cgaarden May 30, 2024
c33a84c
Initial Installer Changes
cgaarden Jun 8, 2024
a72529b
Fixed installer of New+
cgaarden Jun 8, 2024
07e8174
Removed non-used constant and catch if failing to load json state
cgaarden Jun 9, 2024
cd91840
New+ should be disabled by default
cgaarden Jun 11, 2024
2bb29b3
Merge remote-tracking branch 'upstream/main' into NewPlus-v0.1
cgaarden Jun 22, 2024
985b50a
Added a couple of examples templates to the project
cgaarden Jun 28, 2024
0bff942
Merge branch 'NewPlus-v0.1' of https://github.com/cgaarden/PowerToys …
cgaarden Jun 28, 2024
a9faa1c
Merge remote-tracking branch 'upstream/main' into NewPlus-v0.1
cgaarden Jun 28, 2024
adf1254
Updated example templates and initial work on installer (not working …
cgaarden Jun 29, 2024
b98dd4d
Made example templates installable
cgaarden Jun 30, 2024
c994257
Updated installer to install NewPlus Example Templates
cgaarden Jun 30, 2024
5e81c76
Renamed New to NewPlus throughout
cgaarden Jun 30, 2024
5af3cb7
Fixed spelling error
cgaarden Jun 30, 2024
7cb88c5
Additional NewPlus renaming
cgaarden Jun 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 28 additions & 20 deletions .github/actions/spell-check/expect.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ advapi
advfirewall
AFeature
AFFINETRANSFORM
AFolder
AFX
AGGREGATABLE
AHybrid
Expand Down Expand Up @@ -77,6 +78,8 @@ asf
AShortcut
ASingle
ASSOCCHANGED
ASSOCF
ASSOCSTR
ASYNCWINDOWPLACEMENT
ASYNCWINDOWPOS
atl
Expand Down Expand Up @@ -200,6 +203,7 @@ cne
CNF
coclass
codeofconduct
codepaths
codereview
Codespaces
codicon
Expand All @@ -215,7 +219,6 @@ comdlg
comexp
cominterop
commandline
COMMANDTITLE
commctrl
commdlg
compmgmt
Expand Down Expand Up @@ -310,6 +313,7 @@ Dedup
DEFAULTBOOTSTRAPPERINSTALLFOLDER
DEFAULTCOLOR
DEFAULTFLAGS
DEFAULTICON
DEFAULTONLY
DEFAULTTONEAREST
DEFAULTTONULL
Expand All @@ -324,6 +328,7 @@ deletethis
DENORMAL
depersist
deprioritized
DESELECTOTHERS
DESKTOPABSOLUTEEDITING
DESKTOPABSOLUTEPARSING
desktopshorcutinstalled
Expand Down Expand Up @@ -419,11 +424,12 @@ encodedlaunch
encryptor
endpointvolume
ENDSESSION
ENSUREVISIBLE
ENTERSIZEMOVE
ENU
EOAC
epu
EPO
epu
ERASEBKGND
EREOF
EResize
Expand Down Expand Up @@ -465,6 +471,7 @@ exsb
exstyle
EXTENDEDKEY
EXTENDEDVERBS
extention
EXTRINSICPROPERTIES
eyetracker
FANCYZONESDRAWLAYOUTTEST
Expand All @@ -478,7 +485,6 @@ FILEFLAGSMASK
FILELOCKSMITH
FILELOCKSMITHCONTEXTMENU
FILELOCKSMITHEXT
FILELOCKSMITHLIB
FILELOCKSMITHLIBINTEROP
FILEMUSTEXIST
FILEOP
Expand All @@ -500,13 +506,15 @@ FOLDERID
folderpath
FORCEMINIMIZE
formatetc
FORPARSING
FRAMECHANGED
frm
Froml
FROMTOUCH
fsmgmt
Functiondiscoverykeys
FZE
gaardmark
gacutil
Gaeilge
Gaidhlig
Expand All @@ -515,7 +523,6 @@ GCLP
gdi
gdiplus
GDISCALED
gdnbaselines
GEmoji
GETCLIENTAREAANIMATION
GETDESKWALLPAPER
Expand All @@ -535,7 +542,6 @@ gpedit
gpo
GPOCA
gpp
GPT
gpu
GSM
gtm
Expand All @@ -556,6 +562,7 @@ Hashset
hashtag
HASHVAL
HASSTRINGS
HASSUBCOMMANDS
hbitmap
hbm
hbmp
Expand Down Expand Up @@ -635,6 +642,7 @@ IBeam
ICapture
IClass
ICONERROR
ICONLOCATION
IData
IDD
IDesktop
Expand All @@ -652,6 +660,7 @@ IFACEMETHOD
IFACEMETHODIMP
IFile
IFilter
IGNOREUNKNOWN
IGraphics
iid
Iindex
Expand Down Expand Up @@ -695,7 +704,6 @@ INSTALLSTARTMENUSHORTCUT
INSTALLSTATE
Inste
Intelli
interactable
Interlop
INTRESOURCE
INVALIDARG
Expand All @@ -714,6 +722,7 @@ ISettings
IShell
isocpp
iss
ISSEPARATOR
ITask
ith
ITHUMBNAIL
Expand All @@ -724,7 +733,6 @@ IWeb
IWIC
iwr
IYUV
JArray
jfi
jfif
jgeosdfsdsgmkedfgdfgdfgbkmhcgcflmi
Expand Down Expand Up @@ -754,7 +762,6 @@ keyremaps
KILLFOCUS
killrunner
Knownfolders
ksh
KSPROPERTY
Kybd
languagesjson
Expand Down Expand Up @@ -790,7 +797,6 @@ LOADFROMFILE
LOBYTE
LOCALDISPLAY
LOCALPACKAGE
localport
LOCALSYSTEM
LOCATIONCHANGE
LOGFONT
Expand Down Expand Up @@ -845,10 +851,10 @@ lwin
LZero
majortype
makecab
MAKELANGID
MAKEINTRESOURCE
MAKEINTRESOURCEA
MAKEINTRESOURCEW
MAKELANGID
makepri
manifestdependency
MAPPEDTOSAMEKEY
Expand Down Expand Up @@ -989,6 +995,8 @@ newdev
NEWDIALOGSTYLE
newitem
newpath
newplus
NEWPLUSCONTEXTMENU
newrow
newsgroups
NIF
Expand All @@ -1001,14 +1009,18 @@ NOAGGREGATION
NOASYNC
NOCLOSEPROCESS
NOCOALESCE
NOCOMM
NOCONFIRMMKDIR
NOCOPYBITS
NOCOPYSECURITYATTRIBS
nodeca
nodoc
NODRAWCAPTION
NODRAWICON
NOINHERITLAYOUT
NOINTERFACE
NOLINKINFO
NOMCX
NOMINMAX
NOMIRRORBITMAP
NOMOVE
Expand Down Expand Up @@ -1067,7 +1079,6 @@ oldtheme
oleaut
OLECHAR
onebranch
OOBEPT
opencode
OPENFILENAME
opensource
Expand Down Expand Up @@ -1105,7 +1116,6 @@ PARTIALCONFIRMATIONDIALOGTITLE
PATCOPY
pathcch
PATHMUSTEXIST
Pathto
PATINVERT
PATPAINT
PAUDIO
Expand Down Expand Up @@ -1246,8 +1256,6 @@ QUERYENDSESSION
QUERYOPEN
QUEUESYNC
QUNS
qwertyuiopasdfghjklzxcvbnm
qwrtyuiopsghjklzxvnm
raf
RAII
RAlt
Expand All @@ -1264,7 +1272,6 @@ RECTDESTINATION
rectp
RECTSOURCE
recyclebin
redirectedfrom
Redist
redistributable
reencode
Expand Down Expand Up @@ -1343,8 +1350,6 @@ runas
rundll
rungameid
RUNLEVEL
runsettings
runspace
runtimeclass
runtimeobject
runtimepack
Expand Down Expand Up @@ -1405,13 +1410,16 @@ SHELLEXECUTEINFO
SHELLEXECUTEINFOW
shellscalingapi
SHFILEINFO
SHFILEOPSTRUCT
SHGDN
SHGDNF
SHGFI
shinfo
shldisp
shlobj
shlwapi
shmem
SHNAMEMAPPING
shobjidl
SHORTCUTATLEAST
shortcutcontrol
Expand Down Expand Up @@ -1517,7 +1525,7 @@ stringtable
stringval
Strm
Strmiids
Strret
strret
strsafe
strutil
sttngs
Expand All @@ -1533,6 +1541,7 @@ svchost
SVGIn
SVGIO
svgz
SVSI
SWC
SWFO
SWP
Expand Down Expand Up @@ -1576,7 +1585,6 @@ TDevice
telem
telephon
templatenamespace
testhost
testprocess
TEXCOORD
TEXTEXTRACTOR
Expand All @@ -1601,7 +1609,6 @@ tlb
tlbimp
TMPVAR
TNP
toggleswitch
Toolhelp
toolkitconverters
Toolset
Expand Down Expand Up @@ -1730,6 +1737,7 @@ VSTHRD
VSTT
vswhere
Vtbl
WANTMAPPINGHANDLE
WANTPALM
wbem
wbemuuid
Expand Down
3 changes: 3 additions & 0 deletions .pipelines/ESRPSigning_core.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,9 @@
"PowerToys.MouseWithoutBordersHelper.dll",
"PowerToys.MouseWithoutBordersHelper.exe",

"WinUI3Apps\\PowerToys.NewPlus.ShellExtension.dll",
"WinUI3Apps\\NewPlusPackage.msix",

"PowerAccent.Core.dll",
"PowerToys.PowerAccent.dll",
"PowerToys.PowerAccent.exe",
Expand Down
16 changes: 16 additions & 0 deletions PowerToys.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,10 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "PowerToys.Settings.DSC.Sche
{020A7474-3601-4160-A159-D7B70B77B15F} = {020A7474-3601-4160-A159-D7B70B77B15F}
EndProjectSection
EndProject
Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "NewShellExtensionContextMenu", "src\modules\New\NewShellExtensionContextMenu\NewShellExtensionContextMenu.vcxproj", "{8ACB33D9-C95B-47D4-8363-9731EE0930A0}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "New", "New", "{CA716AE6-FE5C-40AC-BB8F-2C87912687AC}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|ARM64 = Debug|ARM64
Expand Down Expand Up @@ -2603,6 +2607,16 @@ Global
{1D6893CB-BC0C-46A8-A76C-9728706CA51A}.Release|x64.Build.0 = Release|x64
{1D6893CB-BC0C-46A8-A76C-9728706CA51A}.Release|x86.ActiveCfg = Release|x64
{1D6893CB-BC0C-46A8-A76C-9728706CA51A}.Release|x86.Build.0 = Release|x64
{8ACB33D9-C95B-47D4-8363-9731EE0930A0}.Debug|ARM64.ActiveCfg = Debug|ARM64
{8ACB33D9-C95B-47D4-8363-9731EE0930A0}.Debug|ARM64.Build.0 = Debug|ARM64
{8ACB33D9-C95B-47D4-8363-9731EE0930A0}.Debug|x64.ActiveCfg = Debug|x64
{8ACB33D9-C95B-47D4-8363-9731EE0930A0}.Debug|x64.Build.0 = Debug|x64
{8ACB33D9-C95B-47D4-8363-9731EE0930A0}.Debug|x86.ActiveCfg = Debug|x64
{8ACB33D9-C95B-47D4-8363-9731EE0930A0}.Release|ARM64.ActiveCfg = Release|ARM64
{8ACB33D9-C95B-47D4-8363-9731EE0930A0}.Release|ARM64.Build.0 = Release|ARM64
{8ACB33D9-C95B-47D4-8363-9731EE0930A0}.Release|x64.ActiveCfg = Release|x64
{8ACB33D9-C95B-47D4-8363-9731EE0930A0}.Release|x64.Build.0 = Release|x64
{8ACB33D9-C95B-47D4-8363-9731EE0930A0}.Release|x86.ActiveCfg = Release|x64
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down Expand Up @@ -2819,6 +2833,8 @@ Global
{3A9A791E-94A9-49F8-8401-C11CE288D5FB} = {D1D6BC88-09AE-4FB4-AD24-5DED46A791DD}
{C0974915-8A1D-4BF0-977B-9587D3807AB7} = {D1D6BC88-09AE-4FB4-AD24-5DED46A791DD}
{1D6893CB-BC0C-46A8-A76C-9728706CA51A} = {557C4636-D7E1-4838-A504-7D19B725EE95}
{8ACB33D9-C95B-47D4-8363-9731EE0930A0} = {CA716AE6-FE5C-40AC-BB8F-2C87912687AC}
{CA716AE6-FE5C-40AC-BB8F-2C87912687AC} = {4574FDD0-F61D-4376-98BF-E5A1262C11EC}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {C3A2F9D1-7930-4EF4-A6FC-7EE0A99821D0}
Expand Down
4 changes: 4 additions & 0 deletions src/common/GPOWrapper/GPOWrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,4 +176,8 @@ namespace winrt::PowerToys::GPOWrapper::implementation
{
return static_cast<GpoRuleConfigured>(powertoys_gpo::getAllowedAdvancedPasteOnlineAIModelsValue());
}
GpoRuleConfigured GPOWrapper::GetConfiguredNewEnabledValue()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same as on the policy name. This is confusing. Please rename to NewPlus.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've finally gotten around to renaming to NewPlus throughout. Thanks again.

{
return static_cast<GpoRuleConfigured>(powertoys_gpo::getConfiguredNewEnabledValue());
}
}
1 change: 1 addition & 0 deletions src/common/GPOWrapper/GPOWrapper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ namespace winrt::PowerToys::GPOWrapper::implementation
static GpoRuleConfigured GetConfiguredQoiPreviewEnabledValue();
static GpoRuleConfigured GetConfiguredQoiThumbnailsEnabledValue();
static GpoRuleConfigured GetAllowedAdvancedPasteOnlineAIModelsValue();
static GpoRuleConfigured GetConfiguredNewEnabledValue();
};
}

Expand Down
1 change: 1 addition & 0 deletions src/common/GPOWrapper/GPOWrapper.idl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ namespace PowerToys
static GpoRuleConfigured GetConfiguredQoiPreviewEnabledValue();
static GpoRuleConfigured GetConfiguredQoiThumbnailsEnabledValue();
static GpoRuleConfigured GetAllowedAdvancedPasteOnlineAIModelsValue();
static GpoRuleConfigured GetConfiguredNewEnabledValue();
}
}
}
1 change: 1 addition & 0 deletions src/common/ManagedCommon/ModuleType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,6 @@ public enum ModuleType
MeasureTool,
ShortcutGuide,
PowerOCR,
New,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same as on the policy name. This is confusing. Please rename to NewPlus.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same as on the policy name. This is confusing. Please rename to NewPlus.

Thank you! I've finally gotten around to renaming to NewPlus throughout. Thanks again.

}
}
Loading
Loading