-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add getForbiddenFilenames to \OCP\Util and unify filename sanitizing #45151
Draft
susnux
wants to merge
6
commits into
master
Choose a base branch
from
fix/ensure-blacklist-is-honored
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+677
−331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acff472
to
059efb2
Compare
059efb2
to
54f89f7
Compare
artonge
reviewed
May 7, 2024
374aed6
to
60838bf
Compare
4 tasks
getForbiddenFilenames
to \OCP\Util
and unify filename sanitizing\OCP\Files\FilenameValidator
\OCP\Files\FilenameValidator
1135b01
to
694995f
Compare
come-nc
reviewed
Jun 24, 2024
3 tasks
74de2ee
to
841d19d
Compare
841d19d
to
994dc7b
Compare
994dc7b
to
1968b74
Compare
1968b74
to
8d6cf37
Compare
e3dc322
to
5e160c0
Compare
…ame validation Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
…meValidator Signed-off-by: Ferdinand Thiessen <[email protected]>
…lidation Signed-off-by: Ferdinand Thiessen <[email protected]>
…izing Signed-off-by: Ferdinand Thiessen <[email protected]>
5e160c0
to
a5817ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
enhancement
feedback-requested
php
Pull requests that update Php code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some preparations and refactoring for #44963
Summary
\OCP\Util::getForbiddenFilenames()
)OC_Util::isValidFilename
as it was deprecated for a long time, not used anymore and not checking forbidden filenames\OCP\Files\FileInfo::BLACKLIST_FILES_REGEX
as this was not used anywhere (only in the util function but that is also not used anywhere + in the files app, but never enforced on webdav).Todo⚠️ - Needs discussion
.fileinfo
files. So I dropped it, but should be instead enfore it?Checklist