conversion of rT.variables in mg/dL #327
Open
+18
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to be done in parallel with nightscout/trio-oref#30
This concerns mainly ISF as transmitted from oref to suggestion / enacted. So far I only found one instance where ISF is used.
So far ISF is always transfered from oref in the current user glucose unit, so if mmol/L is used it comes in mmol/L. Therefore currently no conversion is applied in Trio to ISF originating from oref. Drawback is also that a change of user glucose unit will not be reflected in ISF unless a new loop is calculated. Refer also to nightscout/trio-oref#29
Also the watch app needs to adjusted as ISF may also be shown on watch.