Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rT.variables in mg/dL #30

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

mountrcg
Copy link
Contributor

@mountrcg mountrcg commented Jun 20, 2024

First part of fix for #29

Check in Trio needed to find where suggestion.isf is used and apply a glucoseformatter to it. I did not find deviation and BGI being transferred to Trio from oref.

use conversion for rT.reason only
@mountrcg
Copy link
Contributor Author

Checking on rT.target_bg, there seems to be an error in the calculation of insulinForManualBolus

rT.insulinForManualBolus = round((rT.eventualBG - rT.target_bg) / sens, 2);
as it uses a non converted glucose value eventualBGand a converted glucose value target_bg, which will screw up that value for mmol users. Changing rT.target_bg also into non converted value - it duplicates current_bg though.

 use original oref variables instead of reasonTransfer variables
@mountrcg
Copy link
Contributor Author

successful test documented in Trio PR nightscout/Trio#327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

1 participant