Enhance Image and ActionableButton Widget to add ability to copy text #3040

SebaMutuku · 2024-02-06T14:06:29Z

IMPORTANT: Where possible all PRs must be linked to a Github issue

Engineer Checklist

I have written Unit tests for any new feature(s) and edge cases for bug fixes
I have added any strings visible on UI components to the strings.xml file
I have updated the CHANGELOG.md file for any notable changes to the codebase
I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

I have verified Unit tests have been written for any new feature(s) and edge cases
I have verified any strings visible on UI components are in the strings.xml file
I have verifed the CHANGELOG.md file has any notable changes to the codebase
I have verified the solution has been implemented in a configurable and generic way for reuseable components
I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Sample config for this

   {
          "viewType": "CARD",
          "padding": 16,
          "visible": "true",
          "header": {
            "viewType": "COMPOUND_TEXT",
            "primaryText": "THINKMD TASKS",
            "primaryTextColor": "#6F7274",
            "fontSize": 18.0,
            "padding": 16
          },
          "content": [
            {
              "viewType": "BUTTON",
              "smallSized": "true",
              "text": "Share ThinkMD Self Assessment link",
              "status": "DUE",
              "visible": "true",
              "enabled": "@{patientActive}",
              "startIcon": {
                "type": "local",
                "reference": "ic_copy",
                "color": "#0000FF"
              },
              "actions": [
                {
                  "trigger": "ON_CLICK",
                  "workflow": "COPY_TEXT",
                  "params": [
                    {
                      "paramType": "PARAMDATA",
                      "key": "copyText",
                      "value": "https://jakarta-thinkmd-v4-app-2hqzu73qzq-et.a.run.app/#/start/@{patientId}"
                    }
                  ]
                }
              ]
            }
          ]
        },

ellykits

👍 LGTM. Just a simple comment on the test case.

ellykits · 2024-02-06T15:25:38Z

...va/org/smartregister/fhircore/quest/integration/ui/shared/components/ActionableButtonTest.kt

+    composeRule
+      .onNodeWithText("Copy Button Text", useUnmergedTree = true)
+      .assertExists()
+      .assertIsDisplayed()
+      .performClick()


Should there be a verification done for this perform click action?

I will update the test to test on click function instead

codecov · 2024-02-06T16:37:39Z

Codecov Report

Attention: 142 lines in your changes are missing coverage. Please review.

Comparison is base (ad3a737) 64.5% compared to head (eb48629) 29.8%.
Report is 179 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##              main   #3040      +/-   ##
==========================================
- Coverage     64.5%   29.8%   -34.8%     
+ Complexity    1075     652     -423     
==========================================
  Files          218     236      +18     
  Lines         9635   11088    +1453     
  Branches      1897    1935      +38     
==========================================
- Hits          6218    3307    -2911     
- Misses        2234    7350    +5116     
+ Partials      1183     431     -752

Flag	Coverage Δ
engine	`66.1% <71.4%> (-6.6%)`	⬇️
geowidget	`47.2% <ø> (-17.1%)`	⬇️
quest	`5.2% <0.0%> (-53.7%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...core/engine/configuration/ConfigurationRegistry.kt	`68.0% <100.0%> (-9.2%)`	⬇️
...egister/fhircore/quest/ui/main/AppMainViewModel.kt	`4.4% <ø> (-65.2%)`	⬇️
...ter/fhircore/quest/ui/register/RegisterFragment.kt	`5.6% <ø> (-41.2%)`	⬇️
...rcore/engine/configuration/view/ImageProperties.kt	`81.8% <80.0%> (+47.2%)`	⬆️
...gine/configuration/workflow/ApplicationWorkflow.kt	`0.0% <0.0%> (-100.0%)`	⬇️
...ter/fhircore/quest/ui/main/components/AppDrawer.kt	`0.0% <0.0%> (-68.7%)`	⬇️
...egister/fhircore/quest/ui/profile/ProfileScreen.kt	`0.0% <0.0%> (-50.3%)`	⬇️
...fhircore/quest/ui/shared/components/ExtendedFab.kt	`0.0% <0.0%> (-51.4%)`	⬇️
...fhircore/quest/ui/shared/components/ServiceCard.kt	`0.0% <0.0%> (-65.6%)`	⬇️
...ore/quest/ui/shared/components/ActionableButton.kt	`0.0% <0.0%> (-83.4%)`	⬇️
... and 4 more

... and 113 files with indirect coverage changes

…srp/fhircore into fix_issue_3033_add_copy_text_widget

SebaMutuku · 2024-02-08T16:10:39Z

@MargaretNjenga @f-odhiambo , adding the link to be copied as text might jump to 3 lines or more and would not have a better UI/UX. However, we can add a text description instead and then a copy icon
Here's a sample copy link option

Then a toast shows when one clicks on the icon, below message appears

Kindly advise if there's anything needed to change as I fix failing tests

f-odhiambo · 2024-02-09T09:00:37Z

@SebaMutuku Can we add the 'Tap icon ...' text as normal text and not make it look like a hyperlink? Rest of the stuff LGTM

SebaMutuku · 2024-02-09T09:04:16Z

@f-odhiambo This has been updated

f-odhiambo · 2024-02-09T11:45:48Z

@SebaMutuku Let's make the other text grey

SebaMutuku · 2024-02-12T07:15:38Z

@f-odhiambo this is configurable. I only used that color for visibility

pld · 2024-02-12T20:53:04Z

@f-odhiambo @SebaMutuku I have marked this as blocked, it needs design review, fine to continue on functional requirements but it is not efficient to work on the design until @rowo and @HenryRae have reviewed, thank you

HenryRae · 2024-02-13T06:43:26Z

@SebaMutuku @MargaretNjenga what are we trying to archive here with the copy link on the profile?

What does this mean to getting consent from users first about sharing link?

HenryRae · 2024-02-13T10:01:46Z

Here's a link to the proposed design.

cc: @SebaMutuku @MargaretNjenga @f-odhiambo

…srp/fhircore into fix_issue_3033_add_copy_text_widget

SebaMutuku · 2024-02-13T15:33:28Z

@HenryRae this has been effected.
cc @f-odhiambo @pld @MargaretNjenga

pld

looks good! @SebaMutuku can you update the docs to show how to add this copy text link to an app?

SebaMutuku · 2024-02-14T12:21:30Z

@pld updated.

ellykits

LGTM 👍

ellykits · 2024-02-19T08:00:36Z

Address the CI issues @SebaMutuku so we can merge this.

* main: add docs on tagging (#3089) Constrain isAAB option to Boolean type (#3093) Create manual-apk-release.yml (#3003) Fix setting related entity location on Group member and related resources (#3092) Enhance Image and ActionableButton Widget to add ability to copy text (#3040) Add Related entity location tag on newly created resources via configs (#3086) Spotless clean Fixes config resources flagged for upsync 🐛 Clean up

Enhance Actionable Button to add ability to copy text

8dd2984

SebaMutuku added the DNM DO NOT MERGE label Feb 6, 2024

SebaMutuku and others added 4 commits February 6, 2024 17:09

Remove unnecessary icon

b653da5

Run spotlessApply

37f8b56

Remove context as param from Composable function

ffdad0f

Merge branch 'main' into fix_issue_3033_add_copy_text_widget

bae78d8

ellykits reviewed Feb 6, 2024

View reviewed changes

Merge branch 'main' into fix_issue_3033_add_copy_text_widget

889926a

SebaMutuku removed the DNM DO NOT MERGE label Feb 7, 2024

SebaMutuku changed the title ~~Enhance Actionable Button to add ability to copy text~~ Enhance Image WIdget to add ability to copy text Feb 8, 2024

SebaMutuku and others added 6 commits February 8, 2024 11:02

Merge branch 'main' into fix_issue_3033_add_copy_text_widget

23e2cab

Refactor Image Widget to enable on click

4028f40

Merge branch 'fix_issue_3033_add_copy_text_widget' of github.com:open…

0d9565f

…srp/fhircore into fix_issue_3033_add_copy_text_widget

Remove unnecessary ActionableButton previews

0e97195

Add text property

84182ef

Run spotlessApply

5723b56

SebaMutuku added 2 commits February 9, 2024 12:17

Fix failing tests and add test to confirm toast is shown

43fcd0f

Run spotlessApply

e70a605

Add text color

870e97a

pld changed the title ~~Enhance Image WIdget to add ability to copy text~~ Enhance Image Widget to add ability to copy text Feb 12, 2024

pld added the Blocked Item is blocked by another prerequisite label Feb 12, 2024

Merge branch 'main' into fix_issue_3033_add_copy_text_widget

a6ac600

SebaMutuku added 2 commits February 13, 2024 18:32

Update button as per design requirements

fc5091d

Merge branch 'fix_issue_3033_add_copy_text_widget' of github.com:open…

e0d88fa

…srp/fhircore into fix_issue_3033_add_copy_text_widget

SebaMutuku removed the Blocked Item is blocked by another prerequisite label Feb 13, 2024

SebaMutuku added 2 commits February 13, 2024 19:09

Add condition when clicking an image

e2b9fb6

Run spotlessApply on Image.kt

90e5857

SebaMutuku changed the title ~~Enhance Image Widget to add ability to copy text~~ Enhance Image and ActionableButton Widget to add ability to copy text Feb 13, 2024

pld reviewed Feb 13, 2024

View reviewed changes

Add docs for Copy data on actionable button

2d956e9

pld previously approved these changes Feb 15, 2024

View reviewed changes

Merge branch 'main' into fix_issue_3033_add_copy_text_widget

ec0c421

ellykits previously approved these changes Feb 19, 2024

View reviewed changes

SebaMutuku and others added 2 commits February 19, 2024 20:17

Merge branch 'main' into fix_issue_3033_add_copy_text_widget

815aab9

Add tests for ConfigurationRegistry.writeFile()

1658100

SebaMutuku dismissed stale reviews from ellykits and pld via 1658100 February 20, 2024 09:36

Merge branch 'main' into fix_issue_3033_add_copy_text_widget

eb48629

ellykits approved these changes Feb 22, 2024

View reviewed changes

ellykits merged commit 0b03f5b into main Feb 22, 2024
3 of 5 checks passed

ellykits deleted the fix_issue_3033_add_copy_text_widget branch February 22, 2024 07:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhance Image and ActionableButton Widget to add ability to copy text #3040

Enhance Image and ActionableButton Widget to add ability to copy text #3040

SebaMutuku commented Feb 6, 2024 •

edited

Loading

ellykits left a comment

ellykits Feb 6, 2024

SebaMutuku Feb 6, 2024

codecov bot commented Feb 6, 2024 •

edited

Loading

SebaMutuku commented Feb 8, 2024 •

edited

Loading

f-odhiambo commented Feb 9, 2024

SebaMutuku commented Feb 9, 2024 •

edited

Loading

f-odhiambo commented Feb 9, 2024 •

edited

Loading

SebaMutuku commented Feb 12, 2024

pld commented Feb 12, 2024

HenryRae commented Feb 13, 2024 •

edited

Loading

HenryRae commented Feb 13, 2024 •

edited

Loading

SebaMutuku commented Feb 13, 2024

pld left a comment

SebaMutuku commented Feb 14, 2024

ellykits left a comment

ellykits commented Feb 19, 2024

Enhance Image and ActionableButton Widget to add ability to copy text #3040

Enhance Image and ActionableButton Widget to add ability to copy text #3040

Conversation

SebaMutuku commented Feb 6, 2024 • edited Loading

ellykits left a comment

Choose a reason for hiding this comment

ellykits Feb 6, 2024

Choose a reason for hiding this comment

SebaMutuku Feb 6, 2024

Choose a reason for hiding this comment

codecov bot commented Feb 6, 2024 • edited Loading

Codecov Report

SebaMutuku commented Feb 8, 2024 • edited Loading

f-odhiambo commented Feb 9, 2024

SebaMutuku commented Feb 9, 2024 • edited Loading

f-odhiambo commented Feb 9, 2024 • edited Loading

SebaMutuku commented Feb 12, 2024

pld commented Feb 12, 2024

HenryRae commented Feb 13, 2024 • edited Loading

HenryRae commented Feb 13, 2024 • edited Loading

SebaMutuku commented Feb 13, 2024

pld left a comment

Choose a reason for hiding this comment

SebaMutuku commented Feb 14, 2024

ellykits left a comment

Choose a reason for hiding this comment

ellykits commented Feb 19, 2024

SebaMutuku commented Feb 6, 2024 •

edited

Loading

codecov bot commented Feb 6, 2024 •

edited

Loading

SebaMutuku commented Feb 8, 2024 •

edited

Loading

SebaMutuku commented Feb 9, 2024 •

edited

Loading

f-odhiambo commented Feb 9, 2024 •

edited

Loading

HenryRae commented Feb 13, 2024 •

edited

Loading

HenryRae commented Feb 13, 2024 •

edited

Loading