Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(span): add various implementations of FromIn for Atom. #4090

Conversation

rzvxa
Copy link
Collaborator

@rzvxa rzvxa commented Jul 7, 2024

No description provided.

Copy link

graphite-app bot commented Jul 7, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Jul 7, 2024

CodSpeed Performance Report

Merging #4090 will not alter performance

Comparing 07-07-feat_span_add_various_implementations_of_fromin_for_atom_ (44c7fe3) with main (c3f08ce)

Summary

✅ 29 untouched benchmarks

@rzvxa rzvxa force-pushed the 07-07-feat_allocator_introduce_fromin_and_intoin_traits branch from 2c5f10b to 142c528 Compare July 7, 2024 18:45
@rzvxa rzvxa force-pushed the 07-07-feat_span_add_various_implementations_of_fromin_for_atom_ branch from 8815459 to 5899674 Compare July 7, 2024 18:45
@rzvxa rzvxa force-pushed the 07-07-feat_span_add_various_implementations_of_fromin_for_atom_ branch from 5899674 to 6a4cc81 Compare July 7, 2024 21:56
@rzvxa rzvxa marked this pull request as ready for review July 7, 2024 21:58
@Boshen Boshen force-pushed the 07-07-feat_allocator_introduce_fromin_and_intoin_traits branch from 414ec9d to 115ac3b Compare July 8, 2024 07:07
@Boshen Boshen changed the base branch from 07-07-feat_allocator_introduce_fromin_and_intoin_traits to main July 8, 2024 07:11
@Boshen Boshen force-pushed the 07-07-feat_span_add_various_implementations_of_fromin_for_atom_ branch from 6a4cc81 to d805a88 Compare July 8, 2024 07:12
@rzvxa rzvxa force-pushed the 07-07-feat_span_add_various_implementations_of_fromin_for_atom_ branch from d805a88 to ba9da1c Compare July 8, 2024 10:44
@Boshen Boshen added the merge label Jul 8, 2024
Copy link

graphite-app bot commented Jul 8, 2024

Merge activity

  • Jul 8, 11:31 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 8, 11:32 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jul 8, 11:36 AM EDT: Boshen merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 07-07-feat_span_add_various_implementations_of_fromin_for_atom_ branch from 8a285c3 to 44c7fe3 Compare July 8, 2024 15:33
@graphite-app graphite-app bot merged commit 44c7fe3 into main Jul 8, 2024
25 checks passed
@graphite-app graphite-app bot deleted the 07-07-feat_span_add_various_implementations_of_fromin_for_atom_ branch July 8, 2024 15:36
@github-actions github-actions bot mentioned this pull request Jul 9, 2024
Boshen added a commit that referenced this pull request Jul 9, 2024
## [0.18.0] - 2024-07-09

- d347aed ast: [**BREAKING**] Generate `ast_builder.rs`. (#3890) (rzvxa)

### Features

- c6c16a5 minifier: Dce all conditional expressions (#4135) (Boshen)
- 365d9ba oxc_codegen: Generate annotation comments before
`CallExpression` and `NewExpression` (#4119) (IWANABETHATGUY)
- 3a0f2aa parser: Check for illegal modifiers in modules and namespaces
(#4126) (DonIsaac)
- 2f53bdf semantic: Check for abstract ClassElements in non-abstract
classes (#4127) (DonIsaac)
- c4ee9f8 semantic: Check for abstract initializations and
implementations (#4125) (Don Isaac)
- 44c7fe3 span: Add various implementations of `FromIn` for `Atom`.
(#4090) (rzvxa)

### Bug Fixes

- cb1af04 isolated-declarations: Remove the `async` and `generator`
keywords from `MethodDefinition` (#4130) (Dunqing)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants