Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast_codegen): cleanup usages of the generated outputs. #4116

Conversation

rzvxa
Copy link
Collaborator

@rzvxa rzvxa commented Jul 8, 2024

No description provided.

Copy link

graphite-app bot commented Jul 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@rzvxa rzvxa marked this pull request as ready for review July 8, 2024 11:37
Copy link

codspeed-hq bot commented Jul 8, 2024

CodSpeed Performance Report

Merging #4116 will not alter performance

Comparing 07-08-refactor_ast_codegen_cleanup_usages_of_the_generated_outputs (6db630f) with main (2f53bdf)

Summary

✅ 29 untouched benchmarks

@rzvxa rzvxa force-pushed the 06-25-feat_ast_codegen_generate_ast_builder.rs_ branch from b98e220 to 62bae25 Compare July 8, 2024 15:21
@rzvxa rzvxa force-pushed the 07-08-refactor_ast_codegen_cleanup_usages_of_the_generated_outputs branch from 901d250 to 84fc1cb Compare July 8, 2024 15:21
@Boshen Boshen force-pushed the 06-25-feat_ast_codegen_generate_ast_builder.rs_ branch from 62bae25 to 266b292 Compare July 8, 2024 15:38
@Boshen Boshen force-pushed the 07-08-refactor_ast_codegen_cleanup_usages_of_the_generated_outputs branch from 84fc1cb to 92f1f29 Compare July 8, 2024 15:38
@rzvxa rzvxa force-pushed the 06-25-feat_ast_codegen_generate_ast_builder.rs_ branch from 266b292 to 97f265b Compare July 8, 2024 17:10
@rzvxa rzvxa force-pushed the 07-08-refactor_ast_codegen_cleanup_usages_of_the_generated_outputs branch from 92f1f29 to 8a32b39 Compare July 8, 2024 17:10
@rzvxa rzvxa force-pushed the 06-25-feat_ast_codegen_generate_ast_builder.rs_ branch from 97f265b to 8d65e15 Compare July 8, 2024 22:28
@rzvxa rzvxa force-pushed the 07-08-refactor_ast_codegen_cleanup_usages_of_the_generated_outputs branch from 8a32b39 to 806206a Compare July 8, 2024 22:28
@overlookmotel overlookmotel force-pushed the 06-25-feat_ast_codegen_generate_ast_builder.rs_ branch from 8d65e15 to b1615c8 Compare July 9, 2024 00:52
@overlookmotel overlookmotel force-pushed the 07-08-refactor_ast_codegen_cleanup_usages_of_the_generated_outputs branch from 806206a to 8f9353c Compare July 9, 2024 00:53
@overlookmotel overlookmotel force-pushed the 06-25-feat_ast_codegen_generate_ast_builder.rs_ branch from b1615c8 to d347aed Compare July 9, 2024 00:57
@overlookmotel overlookmotel changed the base branch from 06-25-feat_ast_codegen_generate_ast_builder.rs_ to main July 9, 2024 01:08
@overlookmotel overlookmotel force-pushed the 07-08-refactor_ast_codegen_cleanup_usages_of_the_generated_outputs branch from 8f9353c to 93ec6ef Compare July 9, 2024 01:08
@Boshen Boshen added the merge label Jul 9, 2024 — with Graphite App
Copy link

graphite-app bot commented Jul 9, 2024

Merge activity

@Boshen Boshen force-pushed the 07-08-refactor_ast_codegen_cleanup_usages_of_the_generated_outputs branch from 93ec6ef to 6db630f Compare July 9, 2024 03:42
@graphite-app graphite-app bot merged commit 6db630f into main Jul 9, 2024
25 checks passed
@graphite-app graphite-app bot deleted the 07-08-refactor_ast_codegen_cleanup_usages_of_the_generated_outputs branch July 9, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants