[master] Use token's eauth key if load omits it. #66662
Conversation
- `get_auth_list` uses the load to perform ACL lookup but if no `eauth` key is present, `__get_acl` immediately returns. - For token-based authentication, where administrators would also like to write a custom eauth ACL module, this update allows `__get_acl` to check for such a module, either via the `eauth_acl_module` configuration value or fallback to the `eauth` module's `acl` function, if defined.
|
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
salt-project-bot-prod-environment
bot
changed the title
What does this PR do?
__get_aclto check for such a module, either via theeauth_acl_moduleconfiguration value or fallback to theeauthmodule'saclfunction, if defined.What issues does this PR fix or reference?
N/A
Previous Behavior
If
load["eauth"]is not defined,__get_acl()immediately returnsNone.New Behavior
In
get_auth_list(), if the"eauth"key is not present in theloaddictionary, but is present in thetokendictionary, the token's"eauth"value is added to theloaddictionary. When__get_acl()is called from withinget_auth_list(), the former can attempt to perform an ACL lookup via theeauth_acl_moduleconfiguration option or fall back to the eauth module'sacl()function, if defined.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.